chore(java-accessapproval): remove extra generated samples#12560
Merged
chore(java-accessapproval): remove extra generated samples#12560
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes a comprehensive set of auto-generated Java sample files for the Access Approval V1 API, including both synchronous and asynchronous implementations for managing approval requests and settings. I have no feedback to provide.
blakeli0
approved these changes
Apr 1, 2026
blakeli0
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove extra generated samples under
java-accessapproval/google-cloud-accessapproval/samples/snippets/generated.The generated samples maintained by the generator are located in
google-cloud-java/java-accessapproval/samplessnippets/generated.These deleted samples were introduced in commit. From the commit message it seems to meant for short term testing and is accidentally left in the code base:
chore: include java generated samples testing recent changes in gapic-generator-java 2.7.0 to write generated samples to files