chore: Migrate remaining Auth commits after monorepo migration#12561
Merged
chore: Migrate remaining Auth commits after monorepo migration#12561
Conversation
* chore(oauth2_http): Improve IdTokenCredentials quality and docs * chore: Fix lint issues Original-PR: googleapis/google-auth-library-java#1909
) * chore: Add ObsoleteApi annotation * chore: Add tests for serializing ImpersonatedCredentials * chore: Restore old code * chore: Update error message * chore: Fix failing test issue * chore: Remove old tests referecing obsolete api functionality Original-PR: googleapis/google-auth-library-java#1908
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors ImpersonatedCredentials to use modern java.time APIs for expiration parsing and marks legacy calendar-based methods as obsolete. It also updates IdTokenCredentials by making fields final and improving its builder. However, a critical issue was found in IdTokenCredentials.java where the constructor fails to initialize the newly final options field and the targetAudience field, which will result in a compilation error.
google-auth-library-java/oauth2_http/java/com/google/auth/oauth2/IdTokenCredentials.java
Show resolved
Hide resolved
chingor13
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.