chore(fix/gapic-version-java-updates): release 1.84.0-SNAPSHOT#12733
Closed
diegomarquezp wants to merge 1 commit intofix/gapic-version-java-updatesfrom
Closed
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request performs a comprehensive version update across multiple modules and Bill of Materials (BOM) files, transitioning from release versions to the next snapshot versions. The changes affect numerous Google Cloud Java libraries and their associated gRPC/proto dependencies. Feedback identifies a redundant dependency entry for google-cloud-datacatalog in the google-cloud-bigquery module's pom.xml that should be removed to maintain a clean configuration.
Comment on lines
196
to
200
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-cloud-datacatalog</artifactId> | ||
| <scope>test</scope> | ||
| <version>1.95.0</version><!-- {x-version-update:google-cloud-datacatalog:current} --> | ||
| <version>1.96.0-SNAPSHOT</version><!-- {x-version-update:google-cloud-datacatalog:current} --> | ||
| </dependency> |
Contributor
There was a problem hiding this comment.
The dependency google-cloud-datacatalog is duplicated in this file (it also appears at lines 148-152). This redundancy should be removed to maintain a clean POM file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 I have created a release beep boop
1.84.0-SNAPSHOT
Updating meta-information for bleeding-edge SNAPSHOT release.
This PR was generated with Release Please. See documentation.