build(sdk-platform-java): Add formatter plugin to the root pom of sdk-platform-java.#12739
Merged
build(sdk-platform-java): Add formatter plugin to the root pom of sdk-platform-java.#12739
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds the fmt-maven-plugin to the root pom.xml with a skip configuration. The review feedback points out that this configuration will disable formatting across all submodules and recommends specifying a version for build reproducibility. It also suggests using false if the goal is to skip only the root POM and notes that the com.spotify.fmt plugin is no longer maintained, recommending a switch to the HubSpot alternative.
diegomarquezp
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running mvn fmt:format would result in errors in the root pom, because the formatter plugin was not migrated. Add formatter plugin to the root pom of sdk-platform-java to resolve the issue.