feat(bqjdbc): Per connection logs - Add BigQueryJdbcMdc#12748
Open
feat(bqjdbc): Per connection logs - Add BigQueryJdbcMdc#12748
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces BigQueryJdbcMdc, a lightweight MDC implementation for the BigQuery JDBC driver using InheritableThreadLocal. Several critical architectural issues were identified: the dynamic creation of InheritableThreadLocal instances per connection is a significant anti-pattern that can lead to memory exhaustion; the static maps hold strong references to BigQueryConnection objects without a removal mechanism, causing memory leaks; and the global getConnectionId method suffers from O(N) complexity and non-deterministic behavior when multiple connections are present on the same thread.
...google-cloud-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryJdbcMdc.java
Show resolved
Hide resolved
...google-cloud-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryJdbcMdc.java
Show resolved
Hide resolved
...google-cloud-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryJdbcMdc.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements BigQueryJdbcMdc using an InheritableThreadLocal design and corresponding unit tests for verfication.