chore(spanner): use ReplicaSelector in KeyRangeCache#12749
Open
chore(spanner): use ReplicaSelector in KeyRangeCache#12749
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements latency-based replica selection by adding a LatencyTracker to ChannelEndpoint and updating the ReplicaSelector interface. KeyRangeCache now supports an optional ReplicaSelector for choosing between eligible tablets. Review feedback suggests optimizing ArrayList initialization in KeyRangeCache to prevent resizing and notes that the signature change in ReplicaSelector is a breaking change to the interface.
...panner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/KeyRangeCache.java
Outdated
Show resolved
Hide resolved
...nner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/ReplicaSelector.java
Show resolved
Hide resolved
Integrates the ReplicaSelector in KeyRangeCache, so it can be used to select the best replica to send the request to. This feature is effectively disabled for production, as the ReplicaSelector is set to null by default.
1396402 to
d9a46a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates the ReplicaSelector in KeyRangeCache, so it can be used to select the best replica to send the request to. This feature is effectively disabled for production, as the ReplicaSelector is set to null by default.