test(spanner): add timeouts to AsyncResultSetImplTest#12751
Open
test(spanner): add timeouts to AsyncResultSetImplTest#12751
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces timeouts and improved assertions to AsyncResultSetImplTest.java to prevent tests from hanging indefinitely. Key changes include adding a global Timeout rule, replacing blocking calls like await() and take() with timed versions, and implementing manual deadline checks in loops. The review feedback correctly suggests using System.nanoTime() for monotonic timing and AssertionError for more idiomatic test failure reporting.
...nner/google-cloud-spanner/src/test/java/com/google/cloud/spanner/AsyncResultSetImplTest.java
Outdated
Show resolved
Hide resolved
...nner/google-cloud-spanner/src/test/java/com/google/cloud/spanner/AsyncResultSetImplTest.java
Outdated
Show resolved
Hide resolved
...nner/google-cloud-spanner/src/test/java/com/google/cloud/spanner/AsyncResultSetImplTest.java
Outdated
Show resolved
Hide resolved
The AsyncResultSetImplTest seems to be hanging during some builds. This adds timeouts to some of the test methods, and a global timeout for the tests to prevent it from getting stuck, and instead throwing an error.
e7809ee to
1e9096a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AsyncResultSetImplTest seems to be hanging during some builds. This adds timeouts to some of the test methods, and a global timeout for the tests to prevent it from getting stuck, and instead throwing an error.