fix(bqjdbc): only create Statement object when necessary in BDMetaData#12752
Open
fix(bqjdbc): only create Statement object when necessary in BDMetaData#12752
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors BigQueryDatabaseMetaData by removing the shared BigQueryStatement member and updating various metadata methods to either pass null to BigQueryJsonResultSet or use local statements. A critical issue was identified in getPrimaryKeys, getImportedKeys, and getExportedKeys, where the use of try-with-resources causes the Statement and its associated ResultSet to be closed before the caller can use them. It is recommended to use stmt.closeOnCompletion() to ensure the statement remains open until the result set is processed.
...oud-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryDatabaseMetaData.java
Outdated
Show resolved
Hide resolved
...oud-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryDatabaseMetaData.java
Outdated
Show resolved
Hide resolved
...oud-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryDatabaseMetaData.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/501419313
Remove pre-emptive BigQueryStatement object creation in BigQueryDatabaseMetData constructor.