Skip to content

DO NOT SUBMIT; testing how deleting LocalSystemTest affects coverage#1475

Closed
pongad wants to merge 1 commit intogoogleapis:masterfrom
pongad:nuke-local-test
Closed

DO NOT SUBMIT; testing how deleting LocalSystemTest affects coverage#1475
pongad wants to merge 1 commit intogoogleapis:masterfrom
pongad:nuke-local-test

Conversation

@pongad
Copy link
Copy Markdown
Contributor

@pongad pongad commented Dec 13, 2016

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 13, 2016
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.2%) to 83.339% when pulling 827fdc0 on pongad:nuke-local-test into 15c9e23 on GoogleCloudPlatform:master.

@pongad
Copy link
Copy Markdown
Contributor Author

pongad commented Dec 13, 2016

@garrettjonesgoogle Are you OK with this change in coverage? The one big change in coverage is in DefaultPubSubRpc. Most of the methods are just calling equivalent methods in Publisher or SubscriberClient. Tests might not reveal much anyway.

One way to test these methods is to mock the clients we generate from toolkit. Currently, this is not possible.

  • All methods of the clients are final, so they cannot be mocked.
  • We need to mock UnaryCallable, so that we can return Futures that is prepared for the test. We can't, because UnaryCallable is final.

I'm not sure how serious the problem is, but this means our users cannot mock our clients to test their code.

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

I'd like to see the code covered. I suggest trying to use the auto-generated mock server.

@pongad pongad closed this Jan 11, 2017
@pongad pongad deleted the nuke-local-test branch January 11, 2017 01:51
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
…to v3.15.13 (#1475)

* chore(deps): update dependency com.google.cloud:google-cloud-logging to v3.15.13

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Feb 24, 2026
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
…to v3.15.13 (googleapis#1475)

* chore(deps): update dependency com.google.cloud:google-cloud-logging to v3.15.13

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants