remove profile that disables doclint by neozwu · Pull Request #3225 · googleapis/google-cloud-java

neozwu · 2018-05-02T19:21:11Z

Remove this piece of magic code that automatically activates the profile and disables javadoc lint check. Any javadoc errors will still bite us during releasing where a different profile is activated.

igorbernstein2 · 2018-05-02T20:09:59Z

Why does activating another profile disable this one?

igorbernstein2 · 2018-05-02T20:11:27Z

for example, mvn -Pbaa compile still prints hi using the below pom.xml

<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
   <modelVersion>4.0.0</modelVersion>
   <groupId>com.mycompany.app</groupId>
   <artifactId>my-app</artifactId>
   <version>1</version>
   <profiles>
      <profile>
         <id>moo</id>
         <activation>
            <jdk>[1.8,)</jdk>
         </activation>
         <build>
            <plugins>
               <plugin>
                  <groupId>com.github.ekryd.echo-maven-plugin</groupId>
                  <artifactId>echo-maven-plugin</artifactId>
                  <version>1.2.0</version>
                  <executions>
                     <execution>
                        <phase>compile</phase>
                        <goals>
                           <goal>echo</goal>
                        </goals>
                        <configuration>
                           <message>hi!</message>
                        </configuration>
                     </execution>
                  </executions>
               </plugin>
            </plugins>
         </build>
      </profile>
      <profile>
         <id>baa</id>
      </profile>
   </profiles>
</project>

neozwu · 2018-05-02T20:53:43Z

@igorbernstein2 I think you are right. Multiple profiles can be activated at same time. We had this issue - in circle CI docker image, mvn javadoc:jar won't throw errors (only warnings). But those errrors will be thrown during release process. I thought it had something to do with profiles because release uses "release" profile. I took a second look and this issue doesn't seem to be related to profiles. Nevertheless, I still would like to remove this profile unless there's a reason to keep it.

igorbernstein2 · 2018-05-02T20:57:51Z

No worries. I'll just move it to my ~/.m2/settings.xml

JustinBeckwith · 2018-11-02T17:04:44Z

Greetings folks! This issue is getting a little moldy. Should we drive this one forward, or close it out?

igorbernstein2 · 2018-11-05T19:37:40Z

My original attempt to disable javadoc lint got lost when the directory structure changed. I'm planning on re-introducing the change after reporting change gets unreverted:

#3524 (comment)

To clarify my intent: I would like to disable all java8 doclint warnings about missing parameter docs. This is similar to what gax does:
https://github.com/googleapis/gax-java/blob/master/build.gradle#L186

However in maven this is bit uglier because I have use a profile to conditionally target java8 only

chingor13 · 2018-11-08T23:32:22Z

We can do this by updating to maven-javadoc-plugin 3.0+ and set the doclint configuration option. Adding a work item to #3757

…ryconnection-v1 to v2.43.0 (#3225)

## Description feat: *breaking behavior* rewrite Storage.blobAppendableUpload to be non-blocking and have improved throughput (#3231) Rewrite internals of BlobAppendableUpload to provide non-blocking write calls, and it take advantage of grpc async message handling. When `AppendableUploadWriteableByteChannel#write(ByteBuffer)` is called, an attempt will be made to enqueue the bytes in the outbound queue to GCS. If there is only enough room to partially consume the bytes provided in the `ByteBuffer` the write call will return early specifying the number of bytes actually consumed. As acknowledgements come in from gcs, enqueued messages will be evicted freeing space in the outbound queue. Thereby allowing more bytes to be consumed and enqueued. Given appendable objects are still in private preview I can't quote any metrics here, however preliminary benchmarking of several million objects across a range of sizes show across the board throughput improvments. Because the channel's write call is now non-blocking, if you want to block your application until the full buffer is consumed some new helper methods have been added in StorageChannelUtils to provide blocking behavior. A new method `MinFlushSizeFlushPolicy#withMaxPendingBytes(long)` has been added to allow limiting the number of pending outbound bytes. The default values is 16MiB, but can be configured lower if necessary. ## Release Notes BEGIN_COMMIT_OVERRIDE BEGIN_NESTED_COMMIT feat: *breaking behavior* rewrite Storage.blobAppendableUpload to be non-blocking and have improved throughput (#3231) END_NESTED_COMMIT BEGIN_NESTED_COMMIT feat: add StorageChannelUtils to provide helper methods to perform blocking read/write to/from non-blocking channels (#3231) END_NESTED_COMMIT BEGIN_NESTED_COMMIT feat: add MinFlushSizeFlushPolicy#withMaxPendingBytes(long) (#3231) END_NESTED_COMMIT BEGIN_NESTED_COMMIT fix: update BlobAppendableUploadConfig and FlushPolicy.MinFlushSizeFlushPolicy to default to 4MiB minFlushSize and 16MiB maxPendingBytes (#3249) END_NESTED_COMMIT BEGIN_NESTED_COMMIT fix: make FlushPolicy${Min,Max}FlushSizeFlushPolicy constructors private (#3217) END_NESTED_COMMIT END_COMMIMT_OVERRIDE ## Sub PRs This PR is made of up the following PRs, in sequence 1. #3217 2. #3218 3. #3219 4. #3220 5. #3221 6. #3222 7. #3223 8. #3224 9. #3225 10. #3226 11. #3227 12. #3228 13. #3229 14. #3230 15. #3235 16. #3236 17. #3241 18. #3242 19. #3246 20. #3248 21. #3249 22. #3252

remove profile that disables doclint

f83e29d

neozwu requested a review from garrettjonesgoogle May 2, 2018 19:21

neozwu requested a review from pongad as a code owner May 2, 2018 19:21

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 2, 2018

garrettjonesgoogle requested a review from igorbernstein2 May 2, 2018 19:55

chingor13 closed this Nov 8, 2018

suztomo pushed a commit that referenced this pull request Mar 9, 2026

deps: update dependency com.google.api.grpc:proto-google-cloud-bigque…

a897306

…ryconnection-v1 to v2.43.0 (#3225)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove profile that disables doclint#3225

remove profile that disables doclint#3225
neozwu wants to merge 1 commit intogoogleapis:masterfrom
neozwu:remove-disabling-javadoc

neozwu commented May 2, 2018

Uh oh!

igorbernstein2 commented May 2, 2018

Uh oh!

igorbernstein2 commented May 2, 2018 •

edited

Loading

Uh oh!

neozwu commented May 2, 2018

Uh oh!

igorbernstein2 commented May 2, 2018

Uh oh!

JustinBeckwith commented Nov 2, 2018

Uh oh!

igorbernstein2 commented Nov 5, 2018

Uh oh!

chingor13 commented Nov 8, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

neozwu commented May 2, 2018

Uh oh!

igorbernstein2 commented May 2, 2018

Uh oh!

igorbernstein2 commented May 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

neozwu commented May 2, 2018

Uh oh!

igorbernstein2 commented May 2, 2018

Uh oh!

JustinBeckwith commented Nov 2, 2018

Uh oh!

igorbernstein2 commented Nov 5, 2018

Uh oh!

chingor13 commented Nov 8, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

igorbernstein2 commented May 2, 2018 •

edited

Loading