Skip to content

Fix parent/child spans relationship in Spanner.#3690

Merged
pongad merged 2 commits intogoogleapis:masterfrom
bogdandrutu:spannerspans
Sep 27, 2018
Merged

Fix parent/child spans relationship in Spanner.#3690
pongad merged 2 commits intogoogleapis:masterfrom
bogdandrutu:spannerspans

Conversation

@bogdandrutu
Copy link
Copy Markdown

@bogdandrutu bogdandrutu commented Sep 15, 2018 •
edited
Loading

Parent child relationship between spans is not correct for read and commit operations:

  • CloudSpannerOperation.ExecuteStreamingRead is not a child of CloudSpanner.ReadOnlyTransaction but a child of the parent of CloudSpanner.ReadOnlyTransaction.
  • Sent.google.spanner.v1.Spanner.StreamingRead is not a child of CloudSpannerOperation.ExecuteStreamingRead but a child of the parent of CloudSpanner.ReadOnlyTransaction.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pongad pongad Awaiting requested review from pongad

1 more reviewer

@snehashah16 snehashah16 snehashah16 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bogdandrutu @pongad @snehashah16 @googlebot