feat(migration): print package name at end of git history migration#11139
Merged
vchudnov-g merged 2 commits intogoogleapis:mainfrom Apr 27, 2023
Merged
feat(migration): print package name at end of git history migration#11139vchudnov-g merged 2 commits intogoogleapis:mainfrom
vchudnov-g merged 2 commits intogoogleapis:mainfrom
Conversation
…ration This makes it easier for per-API post processing to pick it up.
atulep
reviewed
Apr 27, 2023
| fi | ||
|
|
||
| popd | ||
| echo "${DISTRIBUTION_NAME}" |
Contributor
There was a problem hiding this comment.
Is this for debugging purposes? If not, I'd add more context to print statement. If it's, I don't think it should be committed.
Contributor
Author
There was a problem hiding this comment.
I added a comment. Also see the internal batch migration script.
atulep
approved these changes
Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.