chore(librarian): add support for proto-only library#14551
Merged
Conversation
a00c433 to
7088dbf
Compare
9cb3dac to
e3be634
Compare
e3be634 to
98fc35a
Compare
This was referenced Sep 26, 2025
ohmayr
reviewed
Sep 29, 2025
ohmayr
reviewed
Sep 29, 2025
Comment on lines
+622
to
+626
| command_parts = [ | ||
| f"protoc {api_path}/*.proto", | ||
| f"--python_out={tmp_dir}", | ||
| f"--pyi_out={tmp_dir}", | ||
| ] |
Contributor
There was a problem hiding this comment.
Have we considered using grpc_tools.protoc instead of running the cli as a subprocess?
Contributor
Author
There was a problem hiding this comment.
Yes, my initial thought is that it's better to use protoc directly because we know which version of protoc we're getting. When we use grpc_tools.protoc, we're relying on grpc_tools to choose the version of protoc which adds unnecessary complexity.
ohmayr
approved these changes
Sep 29, 2025
parthea
added a commit
that referenced
this pull request
Sep 29, 2025
parthea
added a commit
that referenced
this pull request
Sep 29, 2025
This PR depends on #14551. Please review #14551 first Towards googleapis/librarian#1061
parthea
added a commit
that referenced
this pull request
Sep 29, 2025
This PR depends on #14551 and #14587. Please review those PRs first. Towards googleapis/librarian#1076
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards googleapis/librarian#1269