chore: librarian generate pull request: 20260311T100338Z#16068
Closed
chore: librarian generate pull request: 20260311T100338Z#16068
Conversation
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the latest updates from the Compute Engine v1beta API protos into the Python client libraries. It expands the API surface by introducing new listing and version retrieval functionalities for various resources, along with new data models to support these additions. The changes ensure the client library remains synchronized with the upstream API definitions. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request contains auto-generated code from protos. The review has identified a few issues in the generated code, including incorrect docstrings for some client methods and a potential bug in the test generator that seems to be overwriting existing tests, leading to a loss of test coverage. These issues should be addressed in the generator to improve the quality of future generated code.
| req.return_value = response_value | ||
| req.return_value.headers = {"header-1": "value-1", "header-2": "value-2"} | ||
| client.get(request) | ||
| client.get_iam_policy(request) |
Contributor
There was a problem hiding this comment.
The test function test_get_rest_bad_request is incorrectly modified to call client.get_iam_policy(request) instead of client.get(request). This makes the test name misleading and, more importantly, it appears that the test coverage for the get method's bad request scenario has been lost. This seems to be part of a pattern in this file where tests for one method are being overwritten by tests for another, which is a significant issue with the test generation process.
Comment on lines
+951
to
+953
| google.api_core.extended_operation.ExtendedOperation: | ||
| An object representing a extended | ||
| long-running operation. |
Contributor
There was a problem hiding this comment.
The docstring for get_version_unary incorrectly states that the method returns a google.api_core.extended_operation.ExtendedOperation. The method's return type hint is compute.Operation, and it indeed returns a raw compute.Operation object. The docstring should be updated to match the actual return type for consistency and clarity.
Comment on lines
+1133
to
+1135
| google.api_core.extended_operation.ExtendedOperation: | ||
| An object representing a extended | ||
| long-running operation. |
Contributor
There was a problem hiding this comment.
The docstring for get_version_unary incorrectly states that the method returns a google.api_core.extended_operation.ExtendedOperation. The method's return type hint is compute.Operation, and it indeed returns a raw compute.Operation object. The docstring should be updated to match the actual return type for consistency and clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
feat: Update Compute Engine v1beta API to revision 20260227 (#1164)
PiperOrigin-RevId:
Library-IDs: google-cloud-compute-v1beta
Source-link: googleapis/googleapis@c7dbec55
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
googleapis/googleapis@e8a3d842
(exclusive) and
googleapis/googleapis@c7dbec55
(inclusive).
Librarian Version: v1.0.2-0.20260309131826-42ac5c451239
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c