Skip to content

chore: librarian generate pull request: 20260323T185442Z#16144

Merged
ohmayr merged 1 commit intomainfrom
librarian-20260323T185442Z
Mar 23, 2026
Merged

chore: librarian generate pull request: 20260323T185442Z#16144
ohmayr merged 1 commit intomainfrom
librarian-20260323T185442Z

Conversation

@ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Mar 23, 2026

PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.

BEGIN_COMMIT

BEGIN_NESTED_COMMIT
docs: Update Account.account_name documentation for naming restrictions

PiperOrigin-RevId: 884882604
Library-IDs: google-shopping-merchant-accounts
Source-link: googleapis/googleapis@e68f10a4
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: Clarify CheckoutSettings.eligible_destinations usage

PiperOrigin-RevId: 884882604
Library-IDs: google-shopping-merchant-accounts
Source-link: googleapis/googleapis@e68f10a4
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: Refine DeveloperRegistration.developer_email behavior description

PiperOrigin-RevId: 884882604
Library-IDs: google-shopping-merchant-accounts
Source-link: googleapis/googleapis@e68f10a4
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: Add product-ratings to Program documentation

PiperOrigin-RevId: 884882604
Library-IDs: google-shopping-merchant-accounts
Source-link: googleapis/googleapis@e68f10a4
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: Update Region to support radius_area and clarify area type exclusivity

PiperOrigin-RevId: 884882604
Library-IDs: google-shopping-merchant-accounts
Source-link: googleapis/googleapis@e68f10a4
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: Improve TermsOfServiceKind.MERCHANT_CENTER comment

PiperOrigin-RevId: 884882604
Library-IDs: google-shopping-merchant-accounts
Source-link: googleapis/googleapis@e68f10a4
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: Update DeleteUser method description

PiperOrigin-RevId: 884882604
Library-IDs: google-shopping-merchant-accounts
Source-link: googleapis/googleapis@e68f10a4
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: Add CreateTestAccount RPC to Accounts service for creating test-only Merchant Center accounts

PiperOrigin-RevId: 884882604
Library-IDs: google-shopping-merchant-accounts
Source-link: googleapis/googleapis@e68f10a4
END_NESTED_COMMIT

END_COMMIT

This pull request is generated with proto changes between
googleapis/googleapis@256b575f
(exclusive) and
googleapis/googleapis@e68f10a4
(inclusive).

Librarian Version: v0.7.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c

@ohmayr ohmayr requested review from a team as code owners March 23, 2026 18:56
@snippet-bot
Copy link

snippet-bot bot commented Mar 23, 2026

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Mar 23, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the google-shopping-merchant-accounts client library by incorporating a new RPC for creating test accounts, which facilitates isolated development and testing environments. Additionally, it includes several documentation enhancements to improve clarity and accuracy across various services and data types within the API, ensuring developers have precise information for integration.

Highlights

  • New RPC Added: Introduced the CreateTestAccount RPC to the Accounts service, allowing for the creation of test-only Merchant Center accounts for development and testing purposes.
  • Documentation Updates: Updated various documentation strings across the google-shopping-merchant-accounts library, including clarifications for Account.account_name naming restrictions, CheckoutSettings.eligible_destinations usage, DeveloperRegistration.developer_email behavior, Region area type exclusivity, and TermsOfServiceKind.MERCHANT_CENTER.
  • Program Support Extended: Added product-ratings to the list of supported programs in the Program documentation.
  • User Service Description Refinement: Refined the description for the DeleteUser method by removing a redundant sentence.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 23, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new create_test_account method to the AccountsService client library, including its API definitions, transport implementations, and unit tests. Additionally, it updates various docstrings and definitions across programs, regions, checkoutsettings, developerregistration, and termsofservicekind for improved clarity and accuracy. A sentence was also removed from the delete_user docstring. The last_generated_commit in state.yaml was updated, indicating a regeneration of the client library. The review notes that the docstring for the new create_test_account method contains extra spaces that should be corrected for readability.

...hant-accounts/google/shopping/merchant_accounts_v1/services/accounts_service/async_client.py
Comment on lines +552 to +562
- Immutable Type: A test account cannot be converted
into a regular (live) Merchant Center account.
Likewise, a regular account cannot be converted into
a test account.
- Non-Serving Products: Any products, offers, or data
created within a test account will not be published
or made visible to end-users on any Google surfaces.
They are strictly for testing environments.
- Separate Environment: Test accounts operate in a
sandbox-like manner, isolated from live serving and
real user traffic.
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The docstring for create_test_account contains extra spaces that harm readability. For example, regular (live) and cannot be converted. This seems to be an issue in the source proto comment that was propagated during code generation. Please fix the extra spacing.

This issue is also present in the docstrings for this method in client.py and the transports modules.

Suggested change
- Immutable Type: A test account cannot be converted
into a regular (live) Merchant Center account.
Likewise, a regular account cannot be converted into
a test account.
- Non-Serving Products: Any products, offers, or data
created within a test account will not be published
or made visible to end-users on any Google surfaces.
They are strictly for testing environments.
- Separate Environment: Test accounts operate in a
sandbox-like manner, isolated from live serving and
real user traffic.
- Immutable Type: A test account cannot be converted
into a regular (live) Merchant Center account.
Likewise, a regular account cannot be converted into
a test account.
- Non-Serving Products: Any products, offers, or data
created within a test account will not be published
or made visible to end-users on any Google surfaces.
They are strictly for testing environments.
- Separate Environment: Test accounts operate in a
sandbox-like manner, isolated from live serving and
real user traffic.

@ohmayr ohmayr merged commit 75697a6 into main Mar 23, 2026
30 of 31 checks passed
@ohmayr ohmayr deleted the librarian-20260323T185442Z branch March 23, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthea parthea parthea approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ohmayr @parthea