chore: librarian onboard pull request: 20260323T132735Z#16146
chore: librarian onboard pull request: 20260323T132735Z#16146vchudnov-g wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Cloud Client Library for Google Cloud Data Catalog Lineage Config Management. It includes the initial code structure, configuration files, documentation, and necessary setup for managing configurations related to data lineage. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request onboards the new google-cloud-datacatalog-lineage-configmanagement library. The changes are mostly auto-generated. My review focuses on improving metadata for clarity and discoverability, and ensuring code conventions for maintainability are followed. I've identified a few areas for improvement in the repository metadata, __all__ definitions, and test constraints.
| @@ -0,0 +1,16 @@ | |||
| { | |||
| "api_description": "", | |||
There was a problem hiding this comment.
The api_description field is empty. It should be populated with a description of the API to help users understand its purpose.
| "api_description": "", | |
| "api_description": "The Data Lineage Config Management API is used to manage the configuration for Data Lineage. These configs define different configuration options for Lineage customers to control the behavior of lineage systems.", |
| "language": "python", | ||
| "library_type": "GAPIC_AUTO", | ||
| "name": "google-cloud-datacatalog-lineage-configmanagement", | ||
| "name_pretty": "Data Lineage API", |
There was a problem hiding this comment.
The name_pretty value "Data Lineage API" is too generic and is likely shared with other Data Lineage clients. Using a more specific name like "Data Lineage Config Management API" would improve clarity and prevent confusion.
| "name_pretty": "Data Lineage API", | |
| "name_pretty": "Data Lineage Config Management API", |
| __all__ = ( | ||
| "ConfigManagementServiceClient", | ||
| "ConfigManagementServiceAsyncClient", | ||
| "Config", | ||
| "GetConfigRequest", | ||
| "UpdateConfigRequest", | ||
| ) |
There was a problem hiding this comment.
For better maintainability and consistency, the __all__ tuple should be sorted alphabetically.
| __all__ = ( | |
| "ConfigManagementServiceClient", | |
| "ConfigManagementServiceAsyncClient", | |
| "Config", | |
| "GetConfigRequest", | |
| "UpdateConfigRequest", | |
| ) | |
| __all__ = ( | |
| "Config", | |
| "ConfigManagementServiceAsyncClient", | |
| "ConfigManagementServiceClient", | |
| "GetConfigRequest", | |
| "UpdateConfigRequest", | |
| ) |
| __all__ = ( | ||
| "ConfigManagementServiceAsyncClient", | ||
| "Config", | ||
| "ConfigManagementServiceClient", | ||
| "GetConfigRequest", | ||
| "UpdateConfigRequest", | ||
| ) |
There was a problem hiding this comment.
For better maintainability and consistency, the __all__ tuple should be sorted alphabetically.
| __all__ = ( | |
| "ConfigManagementServiceAsyncClient", | |
| "Config", | |
| "ConfigManagementServiceClient", | |
| "GetConfigRequest", | |
| "UpdateConfigRequest", | |
| ) | |
| __all__ = ( | |
| "Config", | |
| "ConfigManagementServiceAsyncClient", | |
| "ConfigManagementServiceClient", | |
| "GetConfigRequest", | |
| "UpdateConfigRequest", | |
| ) |
| google-auth>=2 | ||
| grpcio>=1 | ||
| proto-plus>=1 | ||
| protobuf>=6 |
| google-auth>=2 | ||
| grpcio>=1 | ||
| proto-plus>=1 | ||
| protobuf>=6 |
PR created by the Librarian CLI to onboard a new Cloud Client Library.
BEGIN_COMMIT
feat: onboard a new library
PiperOrigin-RevId: 886640538
Library-IDs: google-cloud-datacatalog-lineage-configmanagement
END_COMMIT
Librarian Version: v0.8.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c