[DRAFT] feat(firestore): add new pipeline expressions#16151
[DRAFT] feat(firestore): add new pipeline expressions#16151daniel-sanche wants to merge 6 commits intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the capabilities of Firestore pipeline expressions by adding a suite of new functions. These additions enhance data manipulation for arrays, timestamps, and maps, and introduce general utility expressions for comparisons and type checking. The changes aim to provide more powerful and flexible ways to process data directly within Firestore queries. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a number of new pipeline expressions, along with corresponding unit and end-to-end tests. The changes are well-structured. I have a few suggestions to improve the implementation and tests:
- Add client-side validation for
map_setarguments to provide better error feedback. - Add assertions to an end-to-end test for timestamp functions to ensure it properly validates the behavior.
- Fix formatting issues in some of the test files.
Overall, this is a great addition. Please see my detailed comments.
| - description: testTimestampTruncExtractDiff | ||
| pipeline: | ||
| - Collection: timestamps | ||
| - Limit: 1 | ||
| - Select: | ||
| - AliasedExpression: | ||
| - FunctionExpression.timestamp_trunc: | ||
| - Field: time | ||
| - Constant: "day" | ||
| - "trunc_day" | ||
| - AliasedExpression: | ||
| - FunctionExpression.timestamp_extract: | ||
| - Field: time | ||
| - Constant: "year" | ||
| - "extract_year" | ||
| - AliasedExpression: | ||
| - FunctionExpression.timestamp_diff: | ||
| - FunctionExpression.timestamp_add: | ||
| - Field: time | ||
| - Constant: "day" | ||
| - Constant: 1 | ||
| - Field: time | ||
| - Constant: "hour" | ||
| - "diff_hours" |
There was a problem hiding this comment.
The test case testTimestampTruncExtractDiff is missing assert_results and/or assert_proto blocks. Without assertions, the test only verifies that the pipeline executes without errors, but it doesn't validate the correctness of the results. Please add assertions to ensure the new expressions work as expected.
| Returns: | ||
| A new `Map` expression representing the map_set operation. | ||
| """ | ||
| args = [ |
There was a problem hiding this comment.
The map_set function accepts a variable number of key-value arguments. If an odd number of arguments is provided in *more_key_values, it will cause a server-side error. It would be better to add a client-side validation to check for an even number of arguments and raise a ValueError if the check fails. This will improve the developer experience by providing immediate and clear feedback.
if len(more_key_values) % 2 != 0:
raise ValueError(
"map_set expects an even number of key-value arguments after the first pair."
)
args = [| - integerValue: '1' | ||
| - integerValue: '2' | ||
| name: array_slice | ||
| name: select No newline at end of file |
There was a problem hiding this comment.
Please add a newline at the end of the file. It's a common convention and helps prevent issues with some tools.
| - "val_is_string" | ||
| assert_results: | ||
| - val_type: "string" | ||
| val_is_string: true No newline at end of file |
There was a problem hiding this comment.
Please add a newline at the end of the file. It's a common convention and helps prevent issues with some tools.
Adds the following expressions:
TODO: Make sure docstrings and arguments align with other languages