Skip to content

feat(firestore): support string expressions#16152

Open
Linchin wants to merge 13 commits intogoogleapis:mainfrom
Linchin:fs-str
Open

feat(firestore): support string expressions#16152
Linchin wants to merge 13 commits intogoogleapis:mainfrom
Linchin:fs-str

Conversation

@Linchin
Copy link
Contributor

@Linchin Linchin commented Mar 24, 2026 •
edited
Loading

  • regex_find()
  • regex_find_all()
  • split()
  • string_repeat()
  • string_replace_all()
  • string_replace_one()
  • string_index_of()

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Mar 24, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the string manipulation capabilities within the Firestore client library by introducing support for regular expression-based searches. Users can now leverage regex_find to locate the first matching substring or regex_find_all to retrieve all matching substrings within a string field, directly within Firestore expressions. This addition provides greater flexibility for advanced data querying and transformation.

Highlights

  • New String Expression Functions: Introduced regex_find and regex_find_all methods to the Expression class, enabling regular expression matching within Firestore string fields.
  • RE2 Syntax Support: The new regex functions utilize the RE2 regular expression syntax, providing powerful pattern matching capabilities.
  • Comprehensive Testing: Added both system-level end-to-end tests and unit tests to ensure the correct functionality and integration of the new regex expression features.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 24, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces regex_find and regex_find_all methods to the Expression class, enhancing string manipulation capabilities within Firestore queries. The implementation is clean, consistent with existing patterns, and well-documented with clear examples. Both unit and system tests have been added to ensure the correctness and proper functioning of these new features. The tests cover basic usage and proper expression construction. Overall, this is a well-implemented and thoroughly tested feature.

@Linchin Linchin marked this pull request as ready for review March 24, 2026 03:39
@Linchin Linchin requested review from a team as code owners March 24, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Linchin