Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modifies the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds the google-cloud-documentai-toolbox entry to the .librarian/state.yaml file, specifying its version and source roots. The reviewer has pointed out a critical contradiction between the PR's title/description, which states the toolbox should be removed, and the actual code change, which adds it. Clarification is needed on the intended action.
| - id: google-cloud-documentai-toolbox | ||
| version: 0.15.1-alpha | ||
| last_generated_commit: "" | ||
| apis: [] | ||
| source_roots: | ||
| - packages/google-cloud-documentai-toolbox | ||
| preserve_regex: [] | ||
| remove_regex: [] | ||
| tag_format: '{id}-v{version}' |
There was a problem hiding this comment.
The pull request title and description state that documentai-toolbox should be removed from the librarian automation. However, the changes in this file show the google-cloud-documentai-toolbox entry being added to the libraries list. This is a direct contradiction between the stated intent of the PR and the actual code modification. Please clarify if the intention was to add or remove this entry, and adjust either the PR title/description or the code accordingly.
Reverts #16135