Skip to content

feat: Add last statement option samples#16499

Open
sgorse123 wants to merge 2 commits intogoogleapis:mainfrom
sgorse123:main
Open

feat: Add last statement option samples#16499
sgorse123 wants to merge 2 commits intogoogleapis:mainfrom
sgorse123:main

Conversation

@sgorse123
Copy link
Copy Markdown

This adds a sample for the last statement option. Support for the option was added in #1313 by @olavloite.

Support for the option was added in googleapis#1313 by @olavloite.
@sgorse123 sgorse123 requested review from a team as code owners April 1, 2026 02:11
@snippet-bot
Copy link
Copy Markdown

snippet-bot bot commented Apr 1, 2026

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the dml_last_statement_option function to both standard and PostgreSQL-dialect Spanner snippets, along with corresponding CLI command support and tests. The review feedback identifies a potential logic error in pg_snippets.py where a renamed subparser command may not be correctly handled in the command dispatch logic. Additionally, the reviewer suggested improvements for region tag placement to maintain consistency, fixed typos in docstrings, and recommended cleaning up extra spaces in SQL string concatenations.

Support for the option was added in googleapis#1313 by @olavloite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants