Skip to content

docs(bigframes): Add docs to the to_csv methods of dataframe and series#16570

Merged
tswast merged 4 commits intomainfrom
sycai_csv_doc
Apr 7, 2026
Merged

docs(bigframes): Add docs to the to_csv methods of dataframe and series#16570
tswast merged 4 commits intomainfrom
sycai_csv_doc

Conversation

@sycai
Copy link
Copy Markdown
Contributor

@sycai sycai commented Apr 7, 2026

Also reformatted two files under rewrite/ dir to make the linter happy.

Fixes b/498602137 🦕

@sycai sycai requested review from a team as code owners April 7, 2026 00:21
@sycai sycai requested a review from TrevorBergeron April 7, 2026 00:21
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds to_csv method stubs to the DataFrame and Series classes within the vendored pandas core. The review feedback correctly identifies that the return type hints for these methods are currently incorrect, suggesting dictionary types instead of the string or None values described in the documentation.

@sycai sycai requested review from chelsea-lin and tswast April 7, 2026 00:25
@tswast tswast merged commit a8fccef into main Apr 7, 2026
31 checks passed
@tswast tswast deleted the sycai_csv_doc branch April 7, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants