feat(storage): Add support for adding blob object in AAOW#16577
feat(storage): Add support for adding blob object in AAOW#16577nidhiii-27 wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the asynchronous appendable object writer to support Blob metadata, allowing content_type and metadata to be set during object creation. The AsyncAppendableObjectWriter and _AsyncWriteObjectStream classes now accept an optional Blob object, and a new test snippet has been added to demonstrate this functionality. Feedback was provided regarding the indentation of the resource_params dictionary in async_write_object_stream.py.
| resource_params = { | ||
| "name": self.object_name, | ||
| "bucket": self._full_bucket_name, | ||
| } |
There was a problem hiding this comment.
The indentation of the resource_params dictionary is incorrect and will cause a SyntaxError. The keys and values should be indented inside the dictionary definition. Additionally, ensure that the dictionary is programmatically sorted to align with repository standards for dictionary key ordering.
resource_params = dict(
sorted(
{
"name": self.object_name,
"bucket": self._full_bucket_name,
}.items()
)
)References
- Python code must follow PEP-8 indentation standards to avoid SyntaxErrors. (link)
- To ensure dictionary keys remain sorted without manual effort, programmatically sort the dictionary instead of relying on manual ordering in the code.
No description provided.