chore: librarian generate pull request: 20260409T191103Z#16598
chore: librarian generate pull request: 20260409T191103Z#16598cloud-sdk-librarian-robot wants to merge 1 commit intomainfrom
Conversation
|
One or more libraries have failed to generate, please review PR description for a list of failed libraries. |
|
I'm not sure if this was created intentionally or not, so adding the do not merge tag just in case. We should make sure this doesn't interfere with the librarian migration My understanding was that no more generations would be happening until the migration is complete |
There was a problem hiding this comment.
Code Review
This pull request introduces support for Deployment Groups in the google-cloud-config library, enabling the management of multiple deployments as a single unit with dependency tracking. It includes new CRUD operations, long-running operations for provisioning/deprovisioning, and support for external value sources in Terraform blueprints. Additionally, the google-shopping-merchant-products library is updated with new base64-encoded name fields for products and product inputs, and a return_policy_label attribute. The review feedback suggests clarifying documentation examples for encoded resource names to avoid confusion between full resource names and product IDs.
| ``accounts/123/productInputs/ZW5-VVN-c2t1LzEyMw`` for the | ||
| decoded product input name | ||
| ``accounts/123/productInputs/en~US~sku/123``. This field can |
There was a problem hiding this comment.
The phrase "for the decoded product input name" is confusing as it might imply the full resource name is decoded. For better clarity, it would be best to refer to the product ID directly.
| ``accounts/123/productInputs/ZW5-VVN-c2t1LzEyMw`` for the | |
| decoded product input name | |
| ``accounts/123/productInputs/en~US~sku/123``. This field can | |
| accounts/123/productInputs/ZW5-VVN-c2t1LzEyMw for a | |
| product input with the ID en~US~sku/123. This field can |
| ``accounts/123/products/ZW5-VVN-c2t1LzEyMw`` for the decoded | ||
| product name ``accounts/123/products/en~US~sku/123``. This | ||
| field can be used directly as input to the API methods that |
There was a problem hiding this comment.
The phrase "for the decoded product name" is confusing as it might imply the full resource name is decoded. For better clarity, it would be best to refer to the product ID directly.
| ``accounts/123/products/ZW5-VVN-c2t1LzEyMw`` for the decoded | |
| product name ``accounts/123/products/en~US~sku/123``. This | |
| field can be used directly as input to the API methods that | |
| accounts/123/products/ZW5-VVN-c2t1LzEyMw for a product | |
| with the ID en~US~sku/123. This field can be used | |
| directly as input to the API methods that |
| name. Example: ``accounts/123/products/ZW5-VVN-c2t1LzEyMw`` | ||
| for the decoded product name | ||
| ``accounts/123/products/en~US~sku/123``. This field can be |
There was a problem hiding this comment.
The phrase "for the decoded product name" is confusing as it might imply the full resource name is decoded. For better clarity, it would be best to refer to the product ID directly.
| name. Example: ``accounts/123/products/ZW5-VVN-c2t1LzEyMw`` | |
| for the decoded product name | |
| ``accounts/123/products/en~US~sku/123``. This field can be | |
| name. Example: accounts/123/products/ZW5-VVN-c2t1LzEyMw | |
| for a product with the ID en~US~sku/123. This field can be |
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
feat: a new field
base64_encoded_nameis added to theProductmessagePiperOrigin-RevId: 896968813
Library-IDs: google-shopping-merchant-products
Source-link: googleapis/googleapis@2aba4849
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: new fields -
base64_encoded_nameandbase64_encoded_productadded to theProductInputmessagePiperOrigin-RevId: 896968813
Library-IDs: google-shopping-merchant-products
Source-link: googleapis/googleapis@2aba4849
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
namein message.google.shopping.merchant.products.v1.ProductInputis changedPiperOrigin-RevId: 896968813
Library-IDs: google-shopping-merchant-products
Source-link: googleapis/googleapis@2aba4849
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
namein message.google.shopping.merchant.products.v1.Productis changedPiperOrigin-RevId: 896968813
Library-IDs: google-shopping-merchant-products
Source-link: googleapis/googleapis@2aba4849
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: adding DeploymentGroups, you can now manage deployment of multiple module root dependencies in a single DAG
PiperOrigin-RevId: 896570259
Library-IDs: google-cloud-config
Source-link: googleapis/googleapis@f5cb7afc
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
googleapis/googleapis@2233f63b
(exclusive) and
googleapis/googleapis@2aba4849
(inclusive).
Librarian Version: v0.0.0-20260407211006-7cd74ea13ba9
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:234b9d1f2ddb057ed7ac6a38db0bf8163d839c65c6cf88ade52530cddebce59e
Generation failed for