refactor(bigframes): enable sqlglot as the default compiler with failsafe mechanism#16602
Draft
chelsea-lin wants to merge 1 commit intomainfrom
Draft
refactor(bigframes): enable sqlglot as the default compiler with failsafe mechanism#16602chelsea-lin wants to merge 1 commit intomainfrom
chelsea-lin wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a compiler fallback mechanism in the BigQueryCachingExecutor, allowing the system to switch from sqlglot to ibis if a BadRequest occurs during compilation. It replaces the compiler utility with a more flexible compile_sql function and adds tracking labels to BigQuery jobs to identify the used compiler. Feedback identifies a critical AttributeError due to an outdated __all__ entry, a typo in the newly added unit tests, and a potential parsing risk when applying sqlglot_ir transformations to SQL generated by the ibis compiler during fallback.
packages/bigframes/tests/unit/session/test_bq_caching_executor.py
Outdated
Show resolved
Hide resolved
5236310 to
c03a02e
Compare
c03a02e to
2b783e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal issue 417774347