Dry run of step 6 of migration process#16608
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the repository to the new librarian system by adding a comprehensive librarian.yaml configuration and updating existing configuration and state files to support google-area120-tables and google-cloud-config. Key feedback includes a critical correction for the tag_format which currently uses invalid characters for Git tags, and recommendations to capitalize API descriptions in both the YAML and JSON metadata files for consistency and professional formatting.
| - docs/README.rst | ||
| default: | ||
| output: packages | ||
| tag_format: '{name}: v{version}' |
There was a problem hiding this comment.
The tag_format contains a colon and a space ({name}: v{version}), both of which are invalid characters for Git reference names (tags). This will cause the release process to fail when attempting to create a tag. Consider using a standard format like {name}-v{version}.
tag_format: '{name}-v{version}'| version: 0.14.0 | ||
| apis: | ||
| - path: google/area120/tables/v1alpha1 | ||
| description_override: provides programmatic methods to the Area 120 Tables API. |
There was a problem hiding this comment.
The description in description_override should start with a capital letter for consistency with other library entries (e.g., line 72) and to ensure professional formatting in generated documentation.
description_override: Provides programmatic methods to the Area 120 Tables API.| "product_documentation": "https://area120.google.com", | ||
| "release_level": "preview", | ||
| "repo": "googleapis/google-cloud-python" | ||
| "api_description": "provides programmatic methods to the Area 120 Tables API.", |
There was a problem hiding this comment.
The api_description should start with a capital letter. This field is typically used as the package description on PyPI and in documentation, so proper capitalization is important for clarity and professionalism.
| "api_description": "provides programmatic methods to the Area 120 Tables API.", | |
| "api_description": "Provides programmatic methods to the Area 120 Tables API.", |
No description provided.