Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the .github/CODEOWNERS file to transition from a general catch-all ownership model to specific team-based notifications. It introduces a summary list of active teams and maps several additional packages to their respective owners while removing the default cloud-sdk teams from individual entries. Feedback was provided regarding the omission of the @googleapis/dkp-team from the new summary list, which is inconsistent with the updated instructions in the file.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the .github/CODEOWNERS file by removing the default catch-all rule and the global cloud-sdk teams, while adding specific owners for various packages and a list of active teams. Feedback suggests re-introducing a catch-all rule to ensure coverage for root-level and configuration files, and sorting the package entries alphabetically for better maintainability.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the .github/CODEOWNERS file by removing the catch-all owner and general teams in favor of specific package-level ownership. It also introduces a reference list of teams. The review feedback highlights that removing the default owner leaves root-level files and CI workflows without designated reviewers and suggests alphabetical sorting for the team list.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the .github/CODEOWNERS file to reorganize team ownership and add several new package mappings. It introduces a list of teams for better visibility and removes the general cloud-sdk-python-team and cloud-sdk-librarian-team from specific package rules. Feedback was provided regarding a misunderstanding of how the catch-all rule interacts with specific path matches, as the current configuration prevents the general team from being notified of changes in the specifically mapped packages.
| # Googlers see b/477912165 and corresponding design doc | ||
|
|
||
| # Catch all. @googleapis/cloud-sdk-python-team is notified on every change for packages not owned by other teams. | ||
| * @googleapis/cloud-sdk-python-team |
There was a problem hiding this comment.
- Does this mean googleapis/cloud-sdk-python-team does not have access to the lines below? Only non-listed repos?
- What about googleapis/cloud-sdk-librarian-team? Should they also have access?
There was a problem hiding this comment.
As long as codeowner review is not enforced in the branch protection settings, everyone with write access to the repo has rights to approve PRs touching any files in the repo.
Fixes b/501166036
Fixes #16081