WIP: dialogflow changes#16643
WIP: dialogflow changes#16643ohmayr wants to merge 1 commit intoexperiment-deterministic-resource-namesfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Dialogflow client libraries by adding new types and service methods, including support for CES apps, tools, and toolsets. It also includes documentation formatting improvements and updates to import statements. I have provided feedback regarding the import ordering, as several files deviate from PEP 8 standards by mixing third-party and local imports without proper separation.
| from google.cloud.dialogflow_v2 import gapic_version as package_version | ||
| from google.oauth2 import service_account # type: ignore |
There was a problem hiding this comment.
This change, and similar changes in other files, disrupt the standard Python import order defined in PEP 8. PEP 8 recommends grouping imports into standard library, third-party, and local application sections, separated by blank lines. The previous code correctly separated the third-party google.oauth2 import from the local google.cloud.dialogflow_v2 import. The new ordering mixes them and removes the separating blank line, which can harm readability and maintainability. It's recommended to revert to the standard import grouping across the project.
For example, the order should be:
from google.oauth2 import service_account # type: ignore
from google.cloud.dialogflow_v2 import gapic_version as package_version| from google.cloud.dialogflow_v2 import gapic_version as package_version | |
| from google.oauth2 import service_account # type: ignore | |
| from google.oauth2 import service_account # type: ignore | |
| from google.cloud.dialogflow_v2 import gapic_version as package_version |
References
- PEP 8 recommends grouping imports into standard library, third-party, and local application sections, separated by blank lines. (link)
| from google.cloud.dialogflow_v2beta1 import gapic_version as package_version | ||
| from google.oauth2 import service_account # type: ignore |
There was a problem hiding this comment.
This change, and similar changes in other files, disrupt the standard Python import order defined in PEP 8. PEP 8 recommends grouping imports into standard library, third-party, and local application sections, separated by blank lines. The previous code correctly separated the third-party google.oauth2 import from the local google.cloud.dialogflow_v2beta1 import. The new ordering mixes them and removes the separating blank line, which can harm readability and maintainability. It's recommended to revert to the standard import grouping across the project.
For example, the order should be:
from google.oauth2 import service_account # type: ignore
from google.cloud.dialogflow_v2beta1 import gapic_version as package_version| from google.cloud.dialogflow_v2beta1 import gapic_version as package_version | |
| from google.oauth2 import service_account # type: ignore | |
| from google.oauth2 import service_account # type: ignore | |
| from google.cloud.dialogflow_v2beta1 import gapic_version as package_version |
References
- PEP 8 recommends grouping imports into standard library, third-party, and local application sections, separated by blank lines. (link)
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕