Skip to content

Never retry on DEADLINE_EXCEEDED error codes. Respect user deadlines. Retry would never succeed, anyway.#7879

Merged
tswast merged 1 commit intomasterfrom
autosynth-bigquery_storage
May 8, 2019
Merged

Never retry on DEADLINE_EXCEEDED error codes. Respect user deadlines. Retry would never succeed, anyway.#7879
tswast merged 1 commit intomasterfrom
autosynth-bigquery_storage

Conversation

@yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented May 8, 2019

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/bigquery_storage/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:d3df563538225ac6caac45d8ad86499500211d1bcb2536955a6dbda15e1b368e
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/bigquery/storage/artman_bigquerystorage_v1beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/bigquerystorage-v1beta1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/bigquery/storage/v1beta1/avro.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/bigquerystorage-v1beta1/google/cloud/bigquery_storage_v1beta1/proto/avro.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/bigquery/storage/v1beta1/table_reference.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/bigquerystorage-v1beta1/google/cloud/bigquery_storage_v1beta1/proto/table_reference.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/bigquery/storage/v1beta1/storage.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/bigquerystorage-v1beta1/google/cloud/bigquery_storage_v1beta1/proto/storage.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/bigquery/storage/v1beta1/read_options.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/bigquerystorage-v1beta1/google/cloud/bigquery_storage_v1beta1/proto/read_options.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/bigquerystorage-v1beta1/google/cloud/bigquery_storage_v1beta1/proto.
synthtool > Replaced 'from google.cloud.bigquery.storage_v1beta1.proto' in google/cloud/bigquery_storage_v1beta1/proto/storage_pb2.py.
synthtool > Replaced 'from google.cloud.bigquery.storage_v1beta1.proto' in google/cloud/bigquery_storage_v1beta1/proto/storage_pb2_grpc.py.
synthtool > Replaced 'google-cloud-bigquerystorage' in google/cloud/bigquery_storage_v1beta1/gapic/big_query_storage_client.py.
synthtool > Replaced 'import google.api_core.gapic_v1.method\n' in google/cloud/bigquery_storage_v1beta1/gapic/big_query_storage_client.py.
synthtool > Replaced 'from google.cloud import bigquery_storage_v1beta1' in tests/unit/gapic/v1beta1/test_big_query_storage_client_v1beta1.py.
synthtool > Replaced 'bigquery_storage_v1beta1.BigQueryStorageClient' in tests/unit/gapic/v1beta1/test_big_query_storage_client_v1beta1.py.
synthtool > Replaced 'return google.api_core.grpc_helpers.create_channel\\(\n(\\s+)address,\n\\s+credentials=.*,\n\\s+scopes=.*,\n' in google/cloud/bigquery_storage_v1beta1/gapic/transports/big_query_storage_grpc_transport.py.
synthtool > Replaced 'if transport:' in google/cloud/bigquery_storage_v1beta1/gapic/big_query_storage_client.py.
synthtool > Replaced 'to_grpc_metadata\\(\\n' in google/cloud/bigquery_storage_v1beta1/gapic/big_query_storage_client.py.
synthtool > Replaced 'metadata.append\\(routing_metadata\\)' in google/cloud/bigquery_storage_v1beta1/gapic/big_query_storage_client.py.
synthtool > Replaced 'if channel is not None and credentials is not None:' in google/cloud/bigquery_storage_v1beta1/gapic/transports/big_query_storage_grpc_transport.py.
synthtool > Replaced 'if channel is None:' in google/cloud/bigquery_storage_v1beta1/gapic/transports/big_query_storage_grpc_transport.py.
synthtool > Replaced 'google.api_core.grpc_helpers.create_channel\\(' in google/cloud/bigquery_storage_v1beta1/gapic/transports/big_query_storage_grpc_transport.py.
Running session blacken
Creating virtualenv using python3.6 in /tmpfs/src/git/autosynth/working_repo/bigquery_storage/.nox/blacken
pip install black
black google tests docs
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_storage/google/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_storage/google/cloud/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_storage/google/cloud/bigquery_storage.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_storage/google/cloud/bigquery_storage_v1beta1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_storage/google/cloud/bigquery_storage_v1beta1/gapic/big_query_storage_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_storage/google/cloud/bigquery_storage_v1beta1/proto/avro_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_storage/google/cloud/bigquery_storage_v1beta1/gapic/transports/big_query_storage_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_storage/google/cloud/bigquery_storage_v1beta1/proto/read_options_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_storage/google/cloud/bigquery_storage_v1beta1/proto/read_options_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_storage/google/cloud/bigquery_storage_v1beta1/proto/avro_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_storage/google/cloud/bigquery_storage_v1beta1/proto/storage_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_storage/google/cloud/bigquery_storage_v1beta1/proto/table_reference_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_storage/google/cloud/bigquery_storage_v1beta1/gapic/big_query_storage_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_storage/google/cloud/bigquery_storage_v1beta1/proto/table_reference_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_storage/google/cloud/bigquery_storage_v1beta1/types.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_storage/tests/unit/gapic/v1beta1/test_big_query_storage_client_v1beta1.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_storage/google/cloud/bigquery_storage_v1beta1/proto/storage_pb2.py
All done! ✨ 🍰 ✨
17 files reformatted, 12 files left unchanged.
Session blacken was successful.
synthtool > Cleaned up 0 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation requested a review from a team May 8, 2019 12:15
@yoshi-automation yoshi-automation force-pushed the autosynth-bigquery_storage branch from 69de1aa to 6af2abd Compare May 8, 2019 12:15
@yoshi-automation yoshi-automation added the api: bigquerystorage Issues related to the BigQuery Storage API. label May 8, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2019
@tseaver tseaver added the codegen label May 8, 2019
@tswast
Copy link
Contributor

tswast commented May 8, 2019

Context from internal CL 247122368:

DEADLINE_EXCEEDED is never safe to retry:

  1. Users can set deadlines which generate DEADLINE_EXCEEDED. We should respect user deadlines.
    2 Retrying after a deadline is exceeded would never work, since gRPC would auto-reject the RPC.

@tswast tswast changed the title [CHANGE ME] Re-generated bigquery_storage to pick up changes in the API or client library generator. Never retry on DEADLINE_EXCEEDED error codes. Respect user deadlines. Retry would never succeed, anyway. May 8, 2019
@tswast tswast merged commit 1925cb2 into master May 8, 2019
tswast added a commit to tswast/google-cloud-python that referenced this pull request May 20, 2019
@tswast
Remove googleapis#7879 and googleapis#7921 from changelog, since they…
319e8ac 
… cancel out.
tswast added a commit that referenced this pull request May 20, 2019
@tswast
Release bigquery_storage 0.5.0 (#8038)
29c92d7 
* Release 0.5.0

* Remove #7879 and #7921 from changelog, since they cancel out.
parthea pushed a commit that referenced this pull request Aug 21, 2025
@tswast
Release bigquery_storage 0.5.0 (#8038)
18f5255 
* Release 0.5.0

* Remove #7879 and #7921 from changelog, since they cancel out.
parthea pushed a commit that referenced this pull request Sep 16, 2025
@tswast @parthea
Release bigquery_storage 0.5.0 (#8038)
1324b90 
* Release 0.5.0

* Remove #7879 and #7921 from changelog, since they cancel out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the BigQuery Storage API. cla: yes This human has signed the Contributor License Agreement. codegen

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yoshi-automation @tswast @tseaver @googlebot