Skip to content
This repository was archived by the owner on Nov 9, 2024. It is now read-only.

fix: rename the type FunnelFilter to FunnelFieldFilter #251

Merged
parthea merged 2 commits into from
Jun 20, 2022
Merged

fix: rename the type FunnelFilter to FunnelFieldFilter #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e775f74
fix!: rename the type `FunnelFilter` to `FunnelFieldFilter`
gcf-owl-bot[bot] Jun 15, 2022
00b5213
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions google/analytics/data_v1alpha/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
from .types.data import Funnel
from .types.data import FunnelBreakdown
from .types.data import FunnelEventFilter
from .types.data import FunnelFilter
from .types.data import FunnelFieldFilter
from .types.data import FunnelFilterExpression
from .types.data import FunnelFilterExpressionList
from .types.data import FunnelNextAction
Expand Down Expand Up @@ -104,7 +104,7 @@
"Funnel",
"FunnelBreakdown",
"FunnelEventFilter",
"FunnelFilter",
"FunnelFieldFilter",
"FunnelFilterExpression",
"FunnelFilterExpressionList",
"FunnelNextAction",
Expand Down
4 changes: 2 additions & 2 deletions google/analytics/data_v1alpha/types/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
Funnel,
FunnelBreakdown,
FunnelEventFilter,
FunnelFilter,
FunnelFieldFilter,
FunnelFilterExpression,
FunnelFilterExpressionList,
FunnelNextAction,
Expand Down Expand Up @@ -102,7 +102,7 @@
"Funnel",
"FunnelBreakdown",
"FunnelEventFilter",
"FunnelFilter",
"FunnelFieldFilter",
"FunnelFilterExpression",
"FunnelFilterExpressionList",
"FunnelNextAction",
Expand Down
5 changes: 4 additions & 1 deletion google/analytics/data_v1alpha/types/analytics_data_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,12 @@ class RunFunnelReportRequest(proto.Message):
If specified, next action adds a dimension to the funnel
visualization sub report response. This next action
dimension expands each funnel step to the unique values of
the next action. For example a breakdown by the
the next action. For example a next action of the
``eventName`` dimension will create rows for several events
(i.e. ``session_start`` & ``click``) and the total.

Next action only supports ``eventName`` and most Page /
Screen dimensions like ``pageTitle`` and ``pagePath``.
funnel_visualization_type (google.analytics.data_v1alpha.types.RunFunnelReportRequest.FunnelVisualizationType):
The funnel visualization type controls the dimensions
present in the funnel visualization sub report response. If
Expand Down
20 changes: 12 additions & 8 deletions google/analytics/data_v1alpha/types/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"SegmentParameterFilterScoping",
"FunnelFilterExpression",
"FunnelFilterExpressionList",
"FunnelFilter",
"FunnelFieldFilter",
"FunnelEventFilter",
"FunnelParameterFilterExpression",
"FunnelParameterFilterExpressionList",
Expand Down Expand Up @@ -884,8 +884,12 @@ class FunnelNextAction(proto.Message):
The dimension column added to the funnel visualization sub
report response. The next action dimension returns the next
dimension value of this dimension after the user has
attained the ``i``\ th funnel step. ``nextActionDimension``
currently only supports the ``eventName`` dimension.
attained the ``i``\ th funnel step.

``nextActionDimension`` currently only supports
``eventName`` and most Page / Screen dimensions like
``pageTitle`` and ``pagePath``. ``nextActionDimension``
cannot be a dimension expression.
limit (int):
The maximum number of distinct values of the breakdown
dimension to return in the response. A ``limit`` of ``5`` is
Expand Down Expand Up @@ -2009,8 +2013,8 @@ class FunnelFilterExpression(proto.Message):
The FunnelFilterExpression is NOT of ``notExpression``.

This field is a member of `oneof`_ ``expr``.
funnel_filter (google.analytics.data_v1alpha.types.FunnelFilter):
A primitive funnel filter.
funnel_field_filter (google.analytics.data_v1alpha.types.FunnelFieldFilter):
A funnel filter for a dimension or metric.

This field is a member of `oneof`_ ``expr``.
funnel_event_filter (google.analytics.data_v1alpha.types.FunnelEventFilter):
Expand Down Expand Up @@ -2042,11 +2046,11 @@ class FunnelFilterExpression(proto.Message):
oneof="expr",
message="FunnelFilterExpression",
)
funnel_filter = proto.Field(
funnel_field_filter = proto.Field(
proto.MESSAGE,
number=4,
oneof="expr",
message="FunnelFilter",
message="FunnelFieldFilter",
)
funnel_event_filter = proto.Field(
proto.MESSAGE,
Expand All @@ -2071,7 +2075,7 @@ class FunnelFilterExpressionList(proto.Message):
)


class FunnelFilter(proto.Message):
class FunnelFieldFilter(proto.Message):
r"""An expression to filter dimension or metric values.

This message has `oneof`_ fields (mutually exclusive fields).
Expand Down