Skip to content
This repository was archived by the owner on Oct 31, 2023. It is now read-only.

chore: remove redundant client#21

Merged
parthea merged 2 commits intomasterfrom
remove-redundant-client
Aug 3, 2021
Merged

chore: remove redundant client#21
parthea merged 2 commits intomasterfrom
remove-redundant-client

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Jul 31, 2021

deletes erroneous client google/dataflow_v1beta3 which is not being updated

@parthea parthea requested a review from a team as a code owner July 31, 2021 11:09
@product-auto-label product-auto-label bot added the api: dataflow Issues related to the googleapis/python-dataflow-client API. label Jul 31, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2021
@busunkim96
Copy link
Contributor

Is this a case where API calls made to v1beta3 never worked?

@parthea
Copy link
Contributor Author

parthea commented Aug 3, 2021

This is a different issue. This is deleting an obsolete client located here. The correct location is here.

@busunkim96
Copy link
Contributor

Ah okay makes sense.

@parthea parthea merged commit 01da92e into master Aug 3, 2021
@parthea parthea deleted the remove-redundant-client branch August 3, 2021 16:38
@busunkim96
Copy link
Contributor

Thinking about this a bit more, shouldn't it be merged as a fix? I'm assuming from google import dataflow or from google import dataflow_v1beta3 worked, so it'd be nice to call it out in the changelog.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: dataflow Issues related to the googleapis/python-dataflow-client API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants