samples: add samples from pubsub/cloud-client#134
samples: add samples from pubsub/cloud-client#134anguillanneuf merged 103 commits intogoogleapis:masterfrom
Conversation
Change-Id: I38b90c10aef72c37188c4520897302933b9d2ea7
Change-Id: Ie95e2e1556a8d97b5321dc86bf8de431aa36a2d5
Change-Id: I12c407d3cdf4a3f9736dfaeca6f20b31df6d310a
Change-Id: Ifebdab0b974cc3d3fe8900a23ca7416fed9e026a
…amples#569) * Add tests for quickstarts * Update secrets
Change-Id: I7dfe60b0f1240dc58a664968fd97ca5a8fa1109d
…on-docs-samples#922) * Auto-update dependencies. * Fix pubsub iam samples
…cs-samples#962) * Fix README rst links * Update all READMEs
…hon-docs-samples#1004) * Auto-update dependencies. * Fix natural language samples * Fix pubsub iam samples * Fix language samples * Fix bigquery samples
…hon-docs-samples#1055) * Auto-update dependencies. * Explicitly use latest bigtable client Change-Id: Id71e9e768f020730e4ca9514a0d7ebaa794e7d9e * Revert language update for now Change-Id: I8867f154e9a5aae00d0047c9caf880e5e8f50c53 * Remove pdb. smh Change-Id: I5ff905fadc026eebbcd45512d4e76e003e3b2b43
Change-Id: I776863091846ee8ff8a70078c8b8d5498cf81ed6
Change-Id: I149fc1242ceb6b2cff8eae7ef18b364dd5c26566
…gleCloudPlatform/python-docs-samples#1121) Change-Id: I03b5eaef8b17ac3dc3c0339fd2c7447bd3e11bd2
…orm/python-docs-samples#1158) * Update Readme.rst to add Python setup guide As requested in b/64770713. This sample is linked in documentation https://cloud.google.com/bigtable/docs/scaling, and it would make more sense to update the guide here than in the documentation. * Update README.rst * Update README.rst * Update README.rst * Update README.rst * Update README.rst * Update install_deps.tmpl.rst * Updated readmegen scripts and re-generated related README files * Fixed the lint error
Change-Id: I0d420f3053f391fa225e4b8179e45fd1138f5c65
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
|
Just opened a PR internally to add the additional Kokoro checks for samples. |
|
@plamut Let's coordinate on the merge because we don't want Cloud docs to link to non-existing samples. I have prepared an internal CL (cl/318355428) for docs so we can merge/submit at roughly the same time. Thanks! Tests are failing due to a missing |
|
@anguillanneuf Generated/updated the templates, including the Re: internal PR - I think it should be fine (can't see its contents), as the samples have been copied from the samples repo. When this is approved an merged, we can just "redirect" the docs to point at the new location. |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
anguillanneuf
left a comment
There was a problem hiding this comment.
Looks good! Thanks!
Sometimes we ask people to clone python-docs-samples and cd into pubsub. Those instructions need to be updated accordingly too :)
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
|
@busunkim96 @anguillanneuf Uh-oh, it appears that the sample history was squash-merged instead of using rebase and merge as specified by the migration doc. How important is the history in this case? Do we need to purge this PR and merge it again with history preserved? |
|
Is it still possible to rebase? If so, please do! Thanks @plamut. And if not, we can live with this mistake. |
This reverts commit e204b86.
sgerrand
left a comment
There was a problem hiding this comment.
It looks like some URLs weren't updated during this migration. I've noted the key ones which are broken.
| - name: Quickstart | ||
| file: quickstart.py |
There was a problem hiding this comment.
It's worth noting that this file doesn't exist.
| =============================================================================== | ||
|
|
||
| .. image:: https://gstatic.com/cloudssh/images/open-btn.png | ||
| :target: https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/GoogleCloudPlatform/python-docs-samples&page=editor&open_in_editor=pubsub/cloud-client/README.rst |
There was a problem hiding this comment.
|
|
||
| .. code-block:: bash | ||
|
|
||
| $ git clone https://github.com/GoogleCloudPlatform/python-docs-samples.git |
There was a problem hiding this comment.
- $ git clone https://github.com/GoogleCloudPlatform/python-docs-samples.git
+ $ git clone https://github.com/googleapis/python-pubsub.gitThis reverts commit e204b86. We want to merge the samples branch *unsquashed* to preserve samples commit history.
This reverts commit e204b86. We want to merge the samples branch *unsquashed* to preserve samples commit history.
Samples from https://github.com/GoogleCloudPlatform/python-docs-samples/tree/master/pubsub/cloud-client
Closes #136.
Towards #131.