Skip to content

feat: add TLS/mTLS support for experimental host #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
sagnghos wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: add TLS/mTLS support for experimental host #1479

sagnghos wants to merge 2 commits into from

Conversation

@sagnghos
Copy link
Contributor

@sagnghos sagnghos commented Jan 15, 2026

Previously #1452 introduced changes to support python spanner client against spanner experimental host endpoints over insecure communication

This PR extends those changes to support python spanner client connections to experimental host endpoints over TLS / mTLS connections as well. It also includes changes to run Integration Tests against experimental hosts across all 3 modes of network communication (plain-text, TLS, mTLS)

To run IT tests against experimental host set below variables

export SPANNER_EXPERIMENTAL_HOST=localhost:15000

For tls/mTLS set below additonal variables:

  • (mTLS/TLS)
export CA_CERTIFICATE=/tmp/experimental_host/ca-certificates/ca.crt
  • (mTLS)
export CLIENT_CERTIFICATE=/tmp/experimental_host/certs/client.crt
export CLIENT_KEY=/tmp/experimental_host/certs/client.key

Then we can run below command to tigger the tests:

python -m pytest -v -s --disable-warnings  tests/system/

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/python-spanner API. labels Jan 15, 2026
@gemini-code-assist
Copy link

gemini-code-assist bot commented Jan 15, 2026

Summary of Changes

Hello @sagnghos, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Python Spanner client by integrating robust support for secure communication protocols, specifically TLS and mutual TLS (mTLS), when connecting to experimental Spanner host endpoints. This advancement allows developers to establish encrypted and authenticated connections, building upon the existing functionality for insecure experimental host connections. The changes streamline the configuration of secure channels and ensure that the client can interact with experimental hosts under various security requirements, which is validated through updated system tests covering all three communication modes.

Highlights

  • Secure Experimental Host Connections: Added support for TLS and mTLS connections to experimental Spanner host endpoints, extending previous plain-text capabilities.
  • New Connection Parameters: Introduced use_plain_text, ca_certificate, client_certificate, and client_key parameters to spanner_dbapi.connect and spanner_v1.Client for configuring secure connections.
  • Centralized Transport Creation: Implemented a new internal helper function, _create_experimental_host_transport, to encapsulate the logic for creating gRPC channels for experimental hosts, handling plain-text, TLS, and mTLS configurations.
  • Updated System Tests: Modified system tests to leverage the new parameters, enabling comprehensive testing of experimental host connections across plain-text, TLS, and mTLS modes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 15, 2026
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces TLS/mTLS support for experimental host connections in the Python Spanner client, which is a valuable enhancement. The implementation is well-structured, centralizing the channel creation logic in a new _create_experimental_host_transport helper function. The necessary parameters are correctly plumbed through the connect function and Client constructor. I also appreciate the refactoring that moves the experimental_host concern from the Instance to the Client level, which is a more logical placement. I have one suggestion to improve the conciseness of the credential handling logic.

@sagnghos @gemini-code-assist
Simplify _create_experimental_host_transport
1a7d126 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sagnghos