Clarify that subgroupMin/MaxSize bound the compiler's choice of size#5565
Open
andyleiserson wants to merge 1 commit intogpuweb:mainfrom
Open
Clarify that subgroupMin/MaxSize bound the compiler's choice of size#5565andyleiserson wants to merge 1 commit intogpuweb:mainfrom
andyleiserson wants to merge 1 commit intogpuweb:mainfrom
Conversation
Contributor
|
Previews, as seen when this build job started (6843493): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a lot of minimums/maximums in the spec, and the subgroup size limits operate differently than most, which I thought might be worth clarifying here.
There is a more verbose explanation in the WGSL spec that already captures things clearly, so I think this can be considered editorial.