Make tutorials work when installing package from PyPi, bump versions of stuff to latest #769
+1,424
−1,036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s.txt and split out requirements-dev.txt. Version bumps.
…ney/build-upgrades
…ney/build-upgrades
…ies for the tutorials, like py7zr, requests, click.
Change default --data-dir from hardcoded relative path to package-relative path using Path(__file__).parent / "data". This allows the CLI command to work when graphframes is installed via pip, not just from within the project directory. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Required by graphframe.py which imports `override` from typing_extensions. Without this, the CLI fails with ModuleNotFoundError when installed via pip. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #769 +/- ##
==========================================
- Coverage 84.49% 84.44% -0.05%
==========================================
Files 66 66
Lines 3179 3266 +87
Branches 387 409 +22
==========================================
+ Hits 2686 2758 +72
- Misses 493 508 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This pull request aims to make the tutorials work when the package is installed from PyPI and updates various dependency versions to their latest releases. However, the PR contains critical issues with several non-existent package versions.
- Added project-level dependencies and optional tutorial dependencies to enable PyPI installation
- Updated the tutorial download script to use a package-relative data directory instead of a hardcoded path
- Attempted to update multiple development dependencies (black, flake8, isort, pytest, pre-commit, py7zr, requests, click) to newer versions
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| python/pyproject.toml | Added project dependencies, optional tutorial dependencies, and attempted to update dev dependency versions (contains critical version errors) |
| python/graphframes/tutorials/download.py | Updated default data directory to be relative to the module location, making tutorials work when installed from PyPI |
| python/tests/test_graphframes.py | Applied black formatting to test assertions |
| python/graphframes/connect/proto/graphframes_pb2.py | Applied black formatting to generated protobuf code |
| python/graphframes/connect/graphframes_client.py | Applied black formatting to parameter assignments |
| python/docs/underscores.py | Applied black formatting (quotes and spacing) |
| python/docs/epytext.py | Applied black formatting (quotes and spacing) |
| python/docs/conf.py | Applied black formatting (quotes and list/dict formatting) |
| python/dev/build_jar.py | Applied black formatting to path construction |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Remove version specifiers from tutorials extras since specific versions are managed in poetry.lock. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
rjurney
commented
Jan 8, 2026
rjurney
commented
Jan 8, 2026
rjurney
commented
Jan 8, 2026
rjurney
commented
Jan 8, 2026
rjurney
commented
Jan 8, 2026
rjurney
commented
Jan 8, 2026
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Rename --data-dir to -f/--folder for a more intuitive CLI experience. Allows users to specify a custom download directory. Example: graphframes stackexchange -f /tmp/data stats.meta Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?