Conversation
Codecov Report
@@ Coverage Diff @@
## master #382 +/- ##
================================================
+ Coverage 88.0933% 88.0983% +0.0050%
================================================
Files 71 72 +1
Lines 2402 2403 +1
Branches 264 264
================================================
+ Hits 2116 2117 +1
Misses 161 161
Partials 125 125
Continue to review full report at Codecov.
|
3e94317 to
9c64360
Compare
This CR updates Typescript to version 4.0.3, @types/node to version 14.11.8, ts-node to version 9.0.0 Also, because of changes in Typescript 3.9.0 (microsoft/TypeScript#32264) the testing becoming failing. The testing (sinon) library uses for stubbing dependencies the enumerable properties of objects. We do not able to use that way if we need to stub some dependency in tests with Typescript 3.9+ versions. The right way is about refactoring code (adding dependency injection, for example), but it's a huge task. Fo resolving that problem, we use the 'tslib 1.13.0' helper module and compile for testing the code with included helpers from that lib. It's at least a working solution until a better way is found. Resolves: OLPEDGE-2315 Signed-off-by: Oleksii Zubko <ext-oleksii.zubko@here.com>
9c64360 to
c4c6134
Compare
andescu
approved these changes
Oct 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CR updates Typescript to version 4.0.3,
@types/node to version 14.11.8,
ts-node to version 9.0.0
Also, because of changes in Typescript 3.9.0
(microsoft/TypeScript#32264)
the testing becoming failing.
The testing (sinon) library uses for stubbing dependencies
the enumerable properties of objects.
We do not able to use that way if we need to stub some dependency
in tests with Typescript 3.9+ versions.
The right way is about refactoring code
(adding dependency injection, for example), but it's a huge task.
For resolving that problem, we use the 'tslib 1.13.0' helper module
and compile for testing the code with included helpers from that lib.
It's at least a working solution until a better way is found.
Resolves: OLPEDGE-2315
Signed-off-by: Oleksii Zubko ext-oleksii.zubko@here.com