wordsmith automatic-link-editing guidance#976
Merged
reschke merged 4 commits intohttpwg:masterfrom Sep 10, 2021
Merged
Conversation
The current text of "ought to ... where possible" is easy to read as saying "if you have the technical capability, do it". There are, however, some subtleties, such as if you get the 308 response over http-not-s, in which case the question of whether or not to re-link is not so clear-cut. Change from "where possible" to "where appropriate" to hint that there is some logic needed here beyond "blindly accept".
royfielding
requested changes
Sep 10, 2021
Member
royfielding
left a comment
There was a problem hiding this comment.
I think that begs a follow-on question about when it is appropriate.
I would be more comfortable with changing the entire sentence to be
The server is suggesting that a user agent with link-editing capability
can permanently replace references to the target URI with one of the
new references sent by the server. However, this suggestion is usually
ignored unless the user agent is actively editing references
(e.g., engaged in authoring content), the connection is secured, and
the origin server is a trusted authority for the content being edited.
Contributor
Author
|
I like Roy's version better than mine :) |
mnot
approved these changes
Sep 10, 2021
reschke
requested changes
Sep 10, 2021
Contributor
reschke
left a comment
There was a problem hiding this comment.
The change itself is good, but it needs to be done for 301 as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current text of "ought to ... where possible" is easy to read
as saying "if you have the technical capability, do it".
There are, however, some subtleties, such as if you get the 308 response
over http-not-s, in which case the question of whether or not to
re-link is not so clear-cut.
Change from "where possible" to "where appropriate" to hint that there
is some logic needed here beyond "blindly accept".
(inspired by follow-up discussions from #914)