Skip to content

fix: Message._parse keyword arguments #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alissonlauffer merged 1 commit into from
Jan 28, 2024
Merged

fix: Message._parse keyword arguments #16

alissonlauffer merged 1 commit into from
Jan 28, 2024

Conversation

@M4hbod
Copy link
Contributor

@M4hbod M4hbod commented Jan 26, 2024 •
edited by HitaloM
Loading

Description

Added missing keywords

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

By sending animation.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

HitaloM
HitaloM approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@HitaloM HitaloM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! It seems good to me. 😉

@HitaloM HitaloM added the bug Something is wrong label Jan 26, 2024
usernein
usernein approved these changes Jan 28, 2024
View reviewed changes
Copy link
Member

@usernein usernein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, thanks for contributing!!

alissonlauffer
alissonlauffer approved these changes Jan 28, 2024
View reviewed changes
Copy link
Member

@alissonlauffer alissonlauffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I had double-checked all Message._parse cases, but it looks like I should triple-check them next time 😆.

@alissonlauffer alissonlauffer merged commit e933fdf into hydrogram:dev Jan 28, 2024
tangyoha pushed a commit to tangyoha/hydrogram that referenced this pull request Jul 14, 2024
@Pranav-Saraswat
Update Python Version (hydrogram#16)
9b6e59b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alissonlauffer alissonlauffer alissonlauffer approved these changes

@usernein usernein usernein approved these changes

@HitaloM HitaloM HitaloM approved these changes

Assignees

No one assigned

Labels

bug Something is wrong

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@M4hbod @alissonlauffer @usernein @HitaloM