Skip to content

feat: cancel interim meeting at materials page#10412

Open
nouralmaa wants to merge 1 commit intoietf-tools:mainfrom
nouralmaa:cancel-meetings-interim
Open

feat: cancel interim meeting at materials page#10412
nouralmaa wants to merge 1 commit intoietf-tools:mainfrom
nouralmaa:cancel-meetings-interim

Conversation

@nouralmaa
Copy link
Contributor

fixes#9887

@rjsparks
Copy link
Member

Thanks for pushing this forward.

This one is going to need additional tests.

The code/template might need additional logic - the view needs to account for whether the meeting has already passed. Look to see if that's already available. Right now, it's gating on whether the materials cutoff has passed for chairs, and ignores whether the meeting is in the past if the user is part of the secretariat.

On these views, the button to cancel should not be presented to anyone for a meeting that has already passed.

@nouralmaa
Copy link
Contributor Author

Thanks for pushing this forward.

This one is going to need additional tests.

The code/template might need additional logic - the view needs to account for whether the meeting has already passed. Look to see if that's already available. Right now, it's gating on whether the materials cutoff has passed for chairs, and ignores whether the meeting is in the past if the user is part of the secretariat.

On these views, the button to cancel should not be presented to anyone for a meeting that has already passed.

Ty for feedback. Just having some connectivity issues, will fix the pr asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants