Skip to content
This repository was archived by the owner on Nov 19, 2018. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions doc/source/command-objects/server.rst
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ Create a new server
[--config-drive <value>|True ]
[--min <count>]
[--max <count>]
[--preemtible]
[--wait]
<server-name>

Expand Down Expand Up @@ -143,6 +144,10 @@ Create a new server

Maximum number of servers to launch (default=1)

.. option:: --preemptible

Indicates that the requested instance is preemptible

.. option:: --wait

Wait for build to complete
Expand Down
8 changes: 7 additions & 1 deletion openstackclient/compute/v2/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,11 @@ def get_parser(self, prog_name):
default=1,
help=_('Maximum number of servers to launch (default=1)'),
)
parser.add_argument(
'--preemptible',
action='store_true',
help=_('Indicates that the requested instance is preemptible'),
)
parser.add_argument(
'--wait',
action='store_true',
Expand Down Expand Up @@ -528,7 +533,8 @@ def take_action(self, parsed_args):
block_device_mapping=block_device_mapping,
nics=nics,
scheduler_hints=hints,
config_drive=config_drive)
config_drive=config_drive,
preemptible=parsed_args.preemptible)

self.log.debug('boot_args: %s', boot_args)
self.log.debug('boot_kwargs: %s', boot_kwargs)
Expand Down
53 changes: 53 additions & 0 deletions openstackclient/tests/compute/v2/test_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,56 @@ def test_server_create_minimal(self):
nics=[],
scheduler_hints={},
config_drive=None,
preemptible=False,
)
# ServerManager.create(name, image, flavor, **kwargs)
self.servers_mock.create.assert_called_with(
self.new_server.name,
self.image,
self.flavor,
**kwargs
)

self.assertEqual(self.columns, columns)
self.assertEqual(self.datalist(), data)

def test_server_create_preemptible(self):
arglist = [
'--image', 'image1',
'--flavor', 'flavor1',
'--preemptible',
self.new_server.name,
]
verifylist = [
('image', 'image1'),
('flavor', 'flavor1'),
('config_drive', False),
('preemptible', True),
('server_name', self.new_server.name),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)

# In base command class ShowOne in cliff, abstract method take_action()
# returns a two-part tuple with a tuple of column names and a tuple of
# data to be shown.
columns, data = self.cmd.take_action(parsed_args)

# Set expected values
kwargs = dict(
meta=None,
files={},
reservation_id=None,
min_count=1,
max_count=1,
security_groups=[],
userdata=None,
key_name=None,
availability_zone=None,
block_device_mapping={},
nics=[],
scheduler_hints={},
config_drive=None,
preemptible=True,
)
# ServerManager.create(name, image, flavor, **kwargs)
self.servers_mock.create.assert_called_with(
Expand Down Expand Up @@ -273,6 +323,7 @@ def test_server_create_with_network(self):
'port-id': 'port1_uuid'}],
scheduler_hints={},
config_drive=None,
preemptible=False,
)
# ServerManager.create(name, image, flavor, **kwargs)
self.servers_mock.create.assert_called_with(
Expand Down Expand Up @@ -332,6 +383,7 @@ def test_server_create_userdata(self, mock_open):
nics=[],
scheduler_hints={},
config_drive=None,
preemptible=False,
)
# ServerManager.create(name, image, flavor, **kwargs)
self.servers_mock.create.assert_called_with(
Expand Down Expand Up @@ -385,6 +437,7 @@ def test_server_create_with_block_device_mapping(self):
nics=[],
scheduler_hints={},
config_drive=None,
preemptible=False,
)
# ServerManager.create(name, image, flavor, **kwargs)
self.servers_mock.create.assert_called_with(
Expand Down