Conversation
DanielNovak
reviewed
Mar 7, 2018
| mViewModel.clearView(); | ||
| if (fragment.getActivity() != null && fragment.getActivity().isFinishing()) { | ||
| removeViewModel(fragment.getActivity()); | ||
| if (fragment.requireActivity().isFinishing()) { |
There was a problem hiding this comment.
this is a change in behaviour, we need to keep fragment.getActivity() != null && fragment.getActivity().isFinishing() to prevent crashes
Collaborator
Author
There was a problem hiding this comment.
I thought that activity shouldn't be null and you just check if activity is finishing. I will rewrite it.
af878fc to
4f61097
Compare
4f61097 to
f84504a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.