Make CompileTestModuleOptions consistent with documentation#275
Merged
big-andy-coates merged 1 commit intojava9-modularity:masterfrom Sep 27, 2025
Merged
Conversation
…and documentation when using Kotlin Script build.
Collaborator
|
Thanks for the fix @markslater - sorry its taken so long to accept it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README section for Fall-back to classpath mode states that using the Kotlin DSL, you can enable classpath mode while running tests with:
tasks { compileTestJava { extensions.configure(CompileTestModuleOptions::class) { compileOnClasspath = true } } }In fact, in version 1.8.15 of the plugin, you have to write
isCompileOnClasspath = true. The reason for this is that the accessor needs to be calledgetCompileOnClasspath()for it to be treated as a property in Kotlin.Note that this doesn't affect the Groovy DSL, and that
TestModuleOptionsworks as documented for both Kotlin and Groovy.I've adjusted the tests to demonstrate the problem, implemented a fix, and deprecated the old method.
Let me know if you want to take a different approach, or you'd like anything adjusting.