Enable AndroidX#2385
Merged
inclement merged 13 commits intokivy:developfrom Mar 30, 2021
RobertFlatt:enable_androidx
Merged
Conversation
added 2 commits
December 28, 2020 15:46
This reverts commit 899afae.
inclement
approved these changes
Mar 30, 2021
Member
inclement
left a comment
There was a problem hiding this comment.
Looks good, thanks.
It seems like it might be worth doing an explicit target api version check to help users avoid activating it accidentally, but I guess it doesn't really matter since older targets are generally not useful.
Contributor
|
Given the multiple "trigger CI" commits it would have been nice if someone had squashed those before merging 😅 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the use of the AndroidX support library, as the current Android support library used by p4a is depreciated.
Implemented as described here https://developer.android.com/jetpack/androidx/migrate
No significant apk size change, until a
android.gradle_dependenciesis specified