Skip to content

Comments

Deprecate ACTIVATE_PRO environment variable#13799

Open
k-a-il wants to merge 1 commit intomainfrom
flc-383-ignore-activate-pro
Open

Deprecate ACTIVATE_PRO environment variable#13799
k-a-il wants to merge 1 commit intomainfrom
flc-383-ignore-activate-pro

Conversation

@k-a-il
Copy link
Contributor

@k-a-il k-a-il commented Feb 19, 2026

Motivation

This PR deprecates the ACTIVATE_PRO environment variable, which is currently used in the Pro repository to determine whether to start the Community or Pro version of LocalStack.

Changes

  • Remove from tracked env variables
  • Add to the list of deprecated env variables

Related

FLC-383

@k-a-il k-a-il added this to the 4.14 milestone Feb 19, 2026
@k-a-il k-a-il self-assigned this Feb 19, 2026
@k-a-il k-a-il added semver: patch Non-breaking changes which can be included in patch releases docs: needed Pull request requires documentation updates notes: needed Pull request should be mentioned in the release notes labels Feb 19, 2026
@k-a-il k-a-il requested a review from alexrashed February 19, 2026 16:14
@k-a-il k-a-il marked this pull request as ready for review February 19, 2026 16:15
@k-a-il k-a-il requested review from simonrw and thrau as code owners February 19, 2026 16:15
@k-a-il k-a-il marked this pull request as draft February 19, 2026 16:16
@k-a-il k-a-il changed the title Ignore ACTIVATE_PRO env variable on startup Ignore ACTIVATE_PRO environment variable on startup Feb 19, 2026
@k-a-il k-a-il changed the title Ignore ACTIVATE_PRO environment variable on startup Deprecate ACTIVATE_PRO environment variable Feb 19, 2026
@k-a-il k-a-il added docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes and removed docs: needed Pull request requires documentation updates notes: needed Pull request should be mentioned in the release notes labels Feb 19, 2026
@github-actions
Copy link

github-actions bot commented Feb 19, 2026 •
edited
Loading

S3 Image Test Results (AMD64 / ARM64)

    2 files      2 suites   7m 41s ⏱️
  573 tests   521 ✅  52 💤 0 ❌
1 146 runs  1 042 ✅ 104 💤 0 ❌

Results for commit 492b22f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 19, 2026 •
edited
Loading

Test Results - Preflight, Unit

23 066 tests  ±0   21 175 ✅ ±0   6m 12s ⏱️ +2s
     1 suites ±0    1 891 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 492b22f. ± Comparison against base commit 4d3429c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 19, 2026 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 1s ⏱️ -2s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 492b22f. ± Comparison against base commit 4d3429c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 19, 2026 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 40m 40s ⏱️
5 738 tests 5 214 ✅ 524 💤 0 ❌
5 744 runs  5 214 ✅ 530 💤 0 ❌

Results for commit 492b22f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 19, 2026 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   2h 6m 12s ⏱️ -48s
5 333 tests ±0  4 965 ✅ ±0  368 💤 ±0  0 ❌ ±0 
5 335 runs  ±0  4 965 ✅ ±0  370 💤 ±0  0 ❌ ±0 

Results for commit 492b22f. ± Comparison against base commit 4d3429c.

♻️ This comment has been updated with latest results.

@k-a-il k-a-il marked this pull request as ready for review February 23, 2026 11:02
@k-a-il k-a-il requested a review from silv-io February 23, 2026 11:02
@k-a-il k-a-il force-pushed the flc-383-ignore-activate-pro branch from 850548a to 492b22f Compare February 23, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexrashed alexrashed Awaiting requested review from alexrashed

@simonrw simonrw Awaiting requested review from simonrw simonrw is a code owner

@thrau thrau Awaiting requested review from thrau thrau is a code owner

@silv-io silv-io Awaiting requested review from silv-io

At least 1 approving review is required to merge this pull request.

Assignees

@k-a-il k-a-il

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.14

Development

Successfully merging this pull request may close these issues.

1 participant

@k-a-il