Fix: Use cell name to identify setup cells when id is null#8137
Merged
Fix: Use cell name to identify setup cells when id is null#8137
Conversation
**Problem** Setup cells don't appear when initializing from __MARIMO_MOUNT_CONFIG__ because the cell data has "id": null with "name": "setup", but the code only checked the id field and generated random IDs instead of using SETUP_CELL_ID. **Solution** Added a getCellId() helper that checks both id and name fields: - If cell.id exists, use it - If cell.name === "setup", use SETUP_CELL_ID - Otherwise, generate a new random ID
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Light2Dark
reviewed
Feb 5, 2026
Comment on lines
+33
to
+35
| if (cell.name === SETUP_CELL_ID) { | ||
| return SETUP_CELL_ID; | ||
| } |
Contributor
There was a problem hiding this comment.
move this before the first check? For future-proofing in case it does have id
Contributor
Author
There was a problem hiding this comment.
in case it does have an id, the id is the source of truth and needs to match the backend
Light2Dark
approved these changes
Feb 5, 2026
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.19.8-dev34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Setup cells don't appear when initializing from MARIMO_MOUNT_CONFIG because the
cell data has "id": null with "name": "setup", but the code only checked the id
field and generated random IDs instead of using SETUP_CELL_ID.
Solution
Added a getCellId() helper that checks both id and name fields: