Skip to content

Conversation

@ishan372or
Copy link

PR summary

PR checklist

@story645 story645 added the status: needs comment/discussion needs consensus on next step label Dec 26, 2025
Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this. I'm not sure if this should go in licensing as it's not a license, but I understand that's where people would look for the information.

Regardless of where this note lands in the docs, it should link to the PR where the colormap was added since that validates the claim.

Comment on lines +102 to +103
As such, it is licensed under the Matplotlib license, unless otherwise
explicitly stated.
Copy link
Member

@story645 story645 Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that's true. @matplotlib/steering-council?

Copy link
Member

@timhoffm timhoffm Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not a legal expert, but that’s my understanding: Contributions to matplotlib without explicit license statement are implicitly licensed under the mpl license. In the case of Turbo, the author has simply relicensed Turbo for matplotlib through contributing.

If we need more formal legal confirmation, we either have to get legal support though Numfocus, or ask the author again.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for flagging this-its sounds fair.I'm happy to soften the language to avoid strong legal assertion and instead document how colormap is treated based on its contribution history

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the language unless you have a lawyer who says it's needed. If the original creator of the PR is the original creator of the colormap, and they didn't assert a separate license, there is nothing to do here. It's just confusing to call this out separately

Co-authored-by: hannah <story645@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: needs comment/discussion needs consensus on next step

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MNT]: Add copyright information for google's "turbo" colormap?

4 participants