-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Added Turbo License doc #30900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added Turbo License doc #30900
Conversation
story645
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this. I'm not sure if this should go in licensing as it's not a license, but I understand that's where people would look for the information.
Regardless of where this note lands in the docs, it should link to the PR where the colormap was added since that validates the claim.
| As such, it is licensed under the Matplotlib license, unless otherwise | ||
| explicitly stated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that's true. @matplotlib/steering-council?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not a legal expert, but that’s my understanding: Contributions to matplotlib without explicit license statement are implicitly licensed under the mpl license. In the case of Turbo, the author has simply relicensed Turbo for matplotlib through contributing.
If we need more formal legal confirmation, we either have to get legal support though Numfocus, or ask the author again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for flagging this-its sounds fair.I'm happy to soften the language to avoid strong legal assertion and instead document how colormap is treated based on its contribution history
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove the language unless you have a lawyer who says it's needed. If the original creator of the PR is the original creator of the colormap, and they didn't assert a separate license, there is nothing to do here. It's just confusing to call this out separately
Co-authored-by: hannah <story645@gmail.com>
PR summary
PR checklist