Prevent blitting errors after canvas swap in RadioButtons and CheckButtons #30945
+17
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttons
This guards blitting-related functionality of RadioButtons and
CheckButtons behind a `self.canvas.supports_blit` check, so that we
don't get errors when trying to call blitting functionality on canvases
that don't support it.
Note: RadioButtons and CheckButtons do still not fully support canvas
swapping as they carry persitent state that depends on blitting
capability ("animated"). This is currently not updated when canvases are
changed. However, this should at most lead to incorrect rendering
in some edge cases after
canvas swap. It will not error out anymore.
In other words the "# TODO: make dynamic" is partially solved, and
reduced to a smaller problem outlined in the new TODO.
Member
Author
|
Test failures are the usual flaky suspects :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This guards blitting-related functionality of RadioButtons and CheckButtons behind a
self.canvas.supports_blitcheck, so that we don't get errors when trying to call blitting functionality on canvases that don't support it.Note: RadioButtons and CheckButtons do still not fully support canvas swapping as they carry persitent state that depends on blitting capability ("animated"). This is currently not updated when canvases are changed. However, this should at most lead to incorrect rendering in some edge cases after canvas swap. It will not error out anymore.
In other words the "# TODO: make dynamic" is partially solved, and
reduced to a smaller problem outlined in the new TODO.
Closes #30575 (again), in particular this fixes the error during figure close in mne-tests reported in #30575 (comment)