MNT: Towards standardizing widget blitting #30974
Open
+36
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To have standard logical framework for blitting of widgets, we pull some logic up into AxesWidget: - Most widgets held a _useblit variable. This is now part of AxesWidget. - AxesWidget._should_use_blit() returns whether blitting should *currently* be done - i.e. the user/widget requested it and the canvas supports it. This is used to guard all blitting-related code. Note: This is a well-defined and limited step towards standardization. Not all widgets are already using it. Some still have special logic. I anticipate that migrating them will be easier when this infrastructure and logical concept is present. Changes here are limited to obvious cases. The rest will be handled in a follow-up PR.
0dea978 to
4f153cf
Compare
timhoffm
commented
Jan 15, 2026
| if self.ignore(event) or self.canvas.is_saving(): | ||
| return | ||
| if self.useblit: | ||
| if self._should_use_blit(): |
Member
Author
There was a problem hiding this comment.
Note: This is a slight change from the static evaluation at init-time to runtime evaluation, but that is the correct thing to do because this is the standard guard for blitting code. Originally there was no difference between a static and a runtime check and we just hadn't decided so far which it should be here.
timhoffm
commented
Jan 15, 2026
| # If you add a call to `ignore` here, you'll want to check edge case: | ||
| # `release` can call a draw event even when `ignore` is True. | ||
| if not self.useblit: | ||
| if not self._should_use_blit(): |
Member
Author
There was a problem hiding this comment.
Note: Same code as in the propertey useblit. This is a standard blitting-code guard. Therefore, I use our new method for that. the property will likely be removed in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step towards #30503.
To have standard logical framework for blitting of widgets, we pull some logic up into AxesWidget:
_useblitvariable. This is now part of AxesWidget, and better explained there 😄AxesWidget._should_use_blit()returns whether blitting should currently be done - i.e. the user/widget requested it and the canvas supports it. This is used to guard all blitting-related code.Note: This is a well-defined and limited step towards standardization. Not all widgets are already using it. Some still have special logic. I anticipate that migrating them will be easier when this infrastructure and logical concept is present. Changes here are limited to obvious cases. The rest will be handled in a follow-up PR.