widgets: use a shared _Buttons class for {Radio,Check}Buttons #30997
+149
−195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For more consistency and similarity with RadioButtons
5 tasks
c5ee840 to
b1eb725
Compare
timhoffm
reviewed
Jan 19, 2026
Member
timhoffm
left a comment
There was a problem hiding this comment.
Please add an entry to widget_api.rst
|
|
||
|
|
||
| class CheckButtons(AxesWidget): | ||
| class _Buttons(AxesWidget): |
Member
There was a problem hiding this comment.
Please add a docstring.
The class should be treated analogous to _SelectorWidget, including
The class itself is private and may be changed or removed without prior warning.
However, the public API it provides to subclasses is stable and considered
public on the subclasses.
Contributor
Author
There was a problem hiding this comment.
Please add a docstring.
Done.
Share all the trivial functions which are identical without any further modifications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
A preparation refactoring commit for #30803 . Changes include:
PR checklist