PERF: Cache ticks and ticklabel bboxes within each draw cycle #31012
+72
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Towards #5665
Currently we are calling
_update_ticks()3 times per axis every draw call, and_get_ticklabel_bboxes2 times per axis. These calls take up about 35% of total draw time for an empty plot.We can eliminate 25% of total draw time by caching the results of these calculations every draw cycle. This introduces some state, but I think it's decently well guarded and the performance boost is definitely worth it.
Before & After
The circled red areas show the before & after runtime of
axis._update_label_positionwithinAxis.draw(). It runs after the cache values have been set by other functions, so we nearly completely eliminate its runtime.Before:

After:

Profiling script:
PR checklist