Skip to content

fix: make the OrgChart story better work #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
tbouffard wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

fix: make the OrgChart story better work #532

tbouffard wants to merge 21 commits into from

Conversation

@tbouffard
Copy link
Member

@tbouffard tbouffard commented Sep 12, 2024 •
edited
Loading

DISCLAIMER: this is a work in progress, force push can occur at any time

Migrate to TypeScript to ease the maintenance

Notes

Inspired by #88
See f7743a6

mxGraph resources

Tasks

@tbouffard tbouffard added the bug Something isn't working label Sep 12, 2024
@tbouffard tbouffard mentioned this pull request Sep 20, 2024
Closed
@tbouffard tbouffard changed the title fix: make the OrgChart story work fix: make the OrgChart story better work Sep 23, 2024
@tbouffard tbouffard mentioned this pull request Nov 2, 2024
Merged
This was referenced Nov 11, 2024
Closed
Merged
@coderabbitai
Copy link

coderabbitai bot commented Nov 23, 2024 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

tbouffard added 19 commits January 2, 2025 18:11
@tbouffard
START fix: make the OrgChart story work
3429c43 
Migrate it to TypeScript to ease the maintenance
@tbouffard
add todo
2875355
@tbouffard
WIP migrate to TS
3c7fb04 
# Conflicts:
#	packages/html/stories/OrgChart.stories.ts
@tbouffard
fix ts errors
7b44d94
@tbouffard
fix ts errors
15568a1
@tbouffard
order imports
4d6370e
@tbouffard
fix TS errors
06ba119
@tbouffard
manage TS errors
f065544
@tbouffard
display the outline
e8663c6 
NOTE TO KEEP
toolbar not displayed
not possible to select/edit the text of the cells
@tbouffard
WIP display the toolbar
10c0b56
@tbouffard
wip: make the delete work with a workaround using the layout.traverse…
6edc73b 
… method instead of calling Graph

[skip ci]
@tbouffard
improve the configuration of the style of outlineContainer
b67c205 
[skip ci]
@tbouffard
improve the configuration of the style of "container"
74ce21f 
[skip ci]
@tbouffard
Graph: add comment about a potential change
f352a57
@tbouffard
WIP toolbar displayed with flex containers
7cdf6d6
@tbouffard
EXTRA TMP fix in VertexMixin.ts manage not passed position or size
8755b6c 
--> check if the JSDoc must be updated if we previously mentioned the properties were mandatory
yes VertexParameters mention mandatory parameters
Should be set except if a LayoutManager or Layout is set on the Graph

# Conflicts:
#	packages/core/src/view/mixins/VertexMixin.ts
@tbouffard
VertexMixin.ts: remove already managed TODO in the main branch
50a74ed
@tbouffard
EXTRA: export treeTraversal.ts in lib
2121595
@tbouffard
story: use the newly treeTraversal exported function
4d83594
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 27, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tbouffard